You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix applied cleanly. The test required updating due to changes in the Class-File API. The modified test fails without the patch, and passes with it.
Progress
Change must be properly reviewed (1 review required, with at least 1 Reviewer)
👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
openjdkbot
changed the title
Backport 20de541b1304b4dc3a385f8a78f1215da237e4aa
8322040: Missing array bounds check in ClassReader.parameter
Dec 19, 2023
@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@cushon This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is a backport of JDK-8322040: Missing array bounds check in ClassReader.parameter.
The fix applied cleanly. The test required updating due to changes in the Class-File API. The modified test fails without the patch, and passes with it.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/4/head:pull/4
$ git checkout pull/4
Update a local copy of the PR:
$ git checkout pull/4
$ git pull https://git.openjdk.org/jdk22u.git pull/4/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4
View PR using the GUI difftool:
$ git pr show -t 4
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/4.diff
Webrev
Link to Webrev Comment