-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8337795: Type annotation attached to incorrect type during class reading #67
Conversation
👋 Welcome back cushon! A progress list of the required criteria for merging this PR into |
@cushon This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 59 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
/approval request This change fixes a bug in javac's handling of type annotations in bytecode, which was logic first added in JDK 22 as part of the fix for JDK-8225377. The patch applies cleanly, and langtools tier1 passes. |
Webrevs
|
@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
The backport has maintainer approval, is there anything else I should be doing to help progress this towards integration? |
Add a "/integrate" comment and I'll sponsor. |
/integrate |
/sponsor |
Going to push as commit a55e476.
Your commit was automatically rebased without conflicts. |
@phohensee @cushon Pushed as commit a55e476. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This change fixes a bug in javac's handling of type annotations in bytecode, which was logic first added in JDK 22 as part of the fix for JDK-8225377.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/67/head:pull/67
$ git checkout pull/67
Update a local copy of the PR:
$ git checkout pull/67
$ git pull https://git.openjdk.org/jdk23u.git pull/67/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 67
View PR using the GUI difftool:
$ git pr show -t 67
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/67.diff
Webrev
Link to Webrev Comment