-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295164: JDK 8 jdi tests should not use tasklist command on Windows #133
Conversation
👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into |
Webrevs
|
@zzambers Shouldn't this also enable windows tier1 tests on GHA? |
@jerboaa, I planned to do separate PR to enable windows jdk_tier1 in GHA. Should I add it to this PR? |
It would make sense to add it here, since it would show what you say (i.e. that it's passing now) |
Interesting, one test failed on Windows x64. I have not seen this failure before (when testing this change). TEST: com/sun/jdi/DoubleAgentTest.java
It is failure of jdi test, but not shell one, and it does not seem related to bug being fixed by this PR. Looks like output got interleaved as result of race condition. Actually this is most probably result of bad design of that particular test, where stdout and stderr are being concurrently collected into single string field named "outputText" [1]. Seems like word "ERROR" got split by text from the other stream, resulting in test failure [2]. Bad luck that "ERROR" word got split :) , but test should definitely be fixed (I'll look at that later). [1]
[2]
|
I'll try to reschedule tests to see, what happens. |
Ok, all tests passed this time. I'll keep this PR as it is and deal with that racy sporadically failing test in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. Thanks for doing this.
@zzambers This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/summary Also enable jdk_tier1 GHA tests on Windows |
@zzambers Please add the summary. Thanks! |
/summary Also enable jdk_tier1 GHA tests on Windows |
@zzambers Setting summary to |
/integrate |
@jerboaa Thanks |
/sponsor |
Going to push as commit 8280a89.
Your commit was automatically rebased without conflicts. |
Shell jdi tests are currently failing on windows. These tests are part of jdk_tier1.
Problem:
Tests fail because ShellScaffold.sh uses (native) tasklist command to check if process with given PID is alive. However this no longer works, since PIDs by Cygwin/Msys2 are no longer same as native Windows PIDs [1][2].
Solution:
Fixed by switching to ps command. Original comment says tasklist was used due to ps sometimes missing some processes. This could be because ps, by default, only shows cygwin processes. I added -W argument to also show native windows processes [3] and I have seen no problems. Fix is targeted for JDK8, since newer JDKs migrated to java based tests (in several steps [4][5][6][7]...), but i think backporting all of that work, just to fix this issue would be overkill. (However nothing prevents anyone from doing so in the future, if desired.)
Testing:
With this fix jdk_tier1 passes for me on Windows.
[1] msys2/MSYS2-packages#1724
[2] https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=b5e1003722cb14235c4f166be72c09acdffc62ea
[3] https://www.cygwin.com/cygwin-ug-net/ps.html
[4] https://bugs.openjdk.org/browse/JDK-8209109
[5] https://bugs.openjdk.org/browse/JDK-8209604
[6] https://bugs.openjdk.org/browse/JDK-8210243
[7] https://bugs.openjdk.org/browse/JDK-8210760
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/133/head:pull/133
$ git checkout pull/133
Update a local copy of the PR:
$ git checkout pull/133
$ git pull https://git.openjdk.org/jdk8u-dev pull/133/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 133
View PR using the GUI difftool:
$ git pr show -t 133
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/133.diff