New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8197859: VS2017 Complains about UINTPTR_MAX definition in globalDefinitions_VisCPP.hpp #58
Conversation
|
This backport pull request has now been updated with issue and summary from the original commit. |
…ler to VS2017 Reviewed-by: jnordstrom, erikj
Reviewed-by: phh Backport-of: 9d59dec200490f11bfc1c661b30f10c7edee3a6d
ping |
Reviewed-by: andrew Backport-of: f42631e354d4abf7994abd92aa5def6b2ceeab3a
Reviewed-by: phh Backport-of: 4d45c3ebc493bb2c85dab84b97840c8ba093ab1f
Backport-of: a95482acf83cc03bc562baace0d55d831d0b2b41
Reviewed-by: sgehwolf
Reviewed-by: sgehwolf Backport-of: b05d4ccf8e54635c16bc2c26aa7a8fcc2e3b3dde
Backport-of: aa90df6f51940a73f9aa078a32768855c8568034
Reviewed-by: phh, zgu Backport-of: 0b9ff0c3a418070996f61f69165de02d33070f7f
8170385: JDK-8031567 broke source bundles 8170392: JDK-8031567 broke builds from source bundles Reviewed-by: sgehwolf Backport-of: 27b7ab8b27a5548ed4cd823d35c8190a594bfdd1
Reviewed-by: sgehwolf
8287508: The tests added to jdk-8 by 8235385 are to be ported to jdk-11 Co-authored-by: Wang Zhuo <wzhuo@openjdk.org> Co-authored-by: Andrew Haley <aph@openjdk.org> Reviewed-by: aph, andrew Backport-of: 156c486e920b1ca406064dd189562b830990f7f9
ping |
|
Hi! Please review another backport from MSVS2019 seria. This one fixes type declarations made by globalDefinitions_VisCPP.hpp. The patch from 11u applied with the following changes:
_MSC_VER >= 1800
because the header was introduced only in MSVS 2013 but we have to keep support of the earlier MSVS versions_MSC_VER < 1800
Verification: 2019 build (both 32/64) now fails with
error (to be fixed by backport of 8043492)
Regression: 2017/2013/2012/2010 full build - ok
@kimbarrett @dholmes-ora if you took a look at that it would be very much appreciated
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/58/head:pull/58
$ git checkout pull/58
Update a local copy of the PR:
$ git checkout pull/58
$ git pull https://git.openjdk.org/jdk8u-dev pull/58/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 58
View PR using the GUI difftool:
$ git pr show -t 58
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/58.diff