8313321 : Set minimum python version in WebKit cmake scripts

[HimaBinduMeda]

Minimum version of python ,to run webkit build , on linux is set to 3.6 and for other platforms, minimum version of python is set to 3.8.

Verified build on all platforms. No issue seen

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8313321: Set minimum python version in WebKit cmake scripts (Bug - P3)

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Joeri Sykora (@tiainen - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1205/head:pull/1205
$ git checkout pull/1205

Update a local copy of the PR:
$ git checkout pull/1205
$ git pull https://git.openjdk.org/jfx.git pull/1205/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1205

View PR using the GUI difftool:
$ git pr show -t 1205

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1205.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 02: Full - Incremental (6e829316)
• 01: Full - Incremental (6b73ba2e)
• 00: Full (c7277d22)

[kevinrushforth]

Reviewers: @kevinrushforth @johanvos @tiainen

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinrushforth]

I tested this on my MacBook Pro running macOS 13.3.1 and discovered that it has python 3.7.x:

  Could NOT find Python3: Found unsuitable version "3.7.3", but required is
  at least "3.8.0" (found /usr/bin/python3, found components: Interpreter)

Since the motivation for checking the minimum was both to avoid python2, and because there is a problem with python 3.7 on Windows, I wonder if it would be better to only have Windows require 3.8 and have Mac join Linux in allowing 3.6. Of course, I could upgrade my python, but I wonder if other developers might run into it.

[HimaBinduMeda]

I tested this on my MacBook Pro running macOS 13.3.1 and discovered that it has python 3.7.x:

  Could NOT find Python3: Found unsuitable version "3.7.3", but required is
  at least "3.8.0" (found /usr/bin/python3, found components: Interpreter)

Since the motivation for checking the minimum was both to avoid python2, and because there is a problem with python 3.7 on Windows, I wonder if it would be better to only have Windows require 3.8 and have Mac join Linux in allowing 3.6. Of course, I could upgrade my python, but I wonder if other developers might run into it.

Based on the observation, changed the minimum version to 3.6 for mac and linux , and 3.8 for Windows

[kevinrushforth]

Looks good.

[johanvos]

I think that should be ok for now, and I don't want to make the PR more complex as this is a good step, but I believe we need more strict checks:

• also check the maximum version for python
• check versions of perl,ruby
  Unfortunately, building webkit is extremely brittle and requiring exact versions is decreasing the chances on failures at build or runtime.

[jgneff]

Just a note that I was unable to build WebKit on Windows using the latest Python version 3.9 that comes with an up-to-date Cygwin installation due to the following issue:

• Windows-style path is not recognized under cygwin

I also couldn't find an easy way to "pin" the version number to keep Cygwin from upgrading it, so I had to revert the version manually each time I ran the Cygwin update tool. See my message on the mailing list for details:

• Cygwin Python 3.9 breaks Windows WebKit build

[bridgekeeper]

@HimaBinduMeda This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[kevinrushforth]

@HimaBinduMeda Can you merge in the latest master? I'll re-review once you do.

Regarding John's comment:

Just a note that I was unable to build WebKit on Windows using the latest Python version 3.9

Let's file a follow-up bug for this if one is not already filed.

[kevinrushforth]

@johanvos or @tiainen could one of you be the second reviewer?

[tiainen]

Looking fine!

[openjdk]

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313321: Set minimum python version in WebKit cmake scripts

Reviewed-by: kcr, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• cd7383a: 8318204: Use new EventTarget methods in ListenerHelper
• 1616924: 8317370: JavaFX runtime version is wrong at runtime
• 6d2595a: 8318115: Webkit build fails after gradle 8.4
• f76437d: 8314906: [testbug] Create behavior tests for text input controls
• 4604e87: 8318059: Typo is javafx.scene.Node.usesMirroring comment
• e621d4b: 8314484: Update Gradle to 8.4

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[HimaBinduMeda]

/integrate

[openjdk]

Going to push as commit bb07bcf.
Since your change was applied there have been 6 commits pushed to the master branch:

• cd7383a: 8318204: Use new EventTarget methods in ListenerHelper
• 1616924: 8317370: JavaFX runtime version is wrong at runtime
• 6d2595a: 8318115: Webkit build fails after gradle 8.4
• f76437d: 8314906: [testbug] Create behavior tests for text input controls
• 4604e87: 8318059: Typo is javafx.scene.Node.usesMirroring comment
• e621d4b: 8314484: Update Gradle to 8.4

Your commit was automatically rebased without conflicts.

[openjdk]

@HimaBinduMeda Pushed as commit bb07bcf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.