New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts #129
Conversation
…9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
…59: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
…mpilable compile scripts
👋 Welcome back ronyfla! A progress list of the required criteria for merging this PR into |
@ronyfla this pull request can no longer be integrated into git checkout scriptCompilable
git fetch https://git.openjdk.java.net/jfx master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
…ce error can be resolved (why would jcheck not do it automagically as well as expanding tabs?)
/reviewers 2 |
@kevinrushforth |
/csr |
@kevinrushforth has indicated that a compatibility and specification (CSR) request is needed for this pull request. |
We will need to finish the discussion on this proposed new feature on the openjfx-dev mailing list. The PR can be used to illustrate what you want to do, but use this email thread, rather than as a reply to the PR, for the discussion. Once we have agreement, then the next step will be to review the proposed spec change and implementation in this PR. |
TODO: ADD DESCRIPTION OF PROPOSED FIX HERE.
Progress
Download
$ git fetch https://git.openjdk.java.net/jfx pull/129/head:pull/129
$ git checkout pull/129