Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts #129

Closed
wants to merge 14 commits into from

Conversation

@ronyfla
Copy link
Contributor

@ronyfla ronyfla commented Feb 28, 2020

TODO: ADD DESCRIPTION OF PROPOSED FIX HERE.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Download

$ git fetch https://git.openjdk.java.net/jfx pull/129/head:pull/129
$ git checkout pull/129

ronyfla added 10 commits Feb 22, 2020
…9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
…59: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
…mpilable compile scripts
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 28, 2020

👋 Welcome back ronyfla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2020

@ronyfla this pull request can no longer be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout scriptCompilable
git fetch https://git.openjdk.java.net/jfx master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push
@openjdk openjdk bot added the merge-conflict label Mar 31, 2020
@openjdk openjdk bot removed the merge-conflict label Mar 31, 2020
ronyfla added 2 commits Mar 31, 2020
…ce error can be resolved (why would jcheck not do it automagically as well as expanding tabs?)
@ronyfla ronyfla changed the title WIP 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts Mar 31, 2020
@openjdk openjdk bot added the rfr label Apr 2, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 2, 2020

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 2, 2020

/csr

@openjdk openjdk bot added the csr label Apr 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2020

@kevinrushforth has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@ronyfla please create a CSR request and add link to it in JDK-8238080. This pull request cannot be integrated until the CSR request is approved.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 2, 2020

We will need to finish the discussion on this proposed new feature on the openjfx-dev mailing list. The PR can be used to illustrate what you want to do, but use this email thread, rather than as a reply to the PR, for the discussion.

Once we have agreement, then the next step will be to review the proposed spec change and implementation in this PR.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 2, 2020

Webrevs

@ronyfla ronyfla changed the title 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts WIP 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts Apr 20, 2020
@openjdk openjdk bot removed the rfr label Apr 20, 2020
@ronyfla ronyfla closed this May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants