-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP add compile PI: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts #187
Conversation
…9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
…59: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
…mpilable compile scripts
…ce error can be resolved (why would jcheck not do it automagically as well as expanding tabs?)
…scripts; PI data can be truei (default) or false
👋 Welcome back ronyfla! A progress list of the required criteria for merging this PR into |
============================ test units for: compile PI tests/system/src/testscriptapp2/java/mymod/myapp2/FXMLScriptDeployment2Compile_Off.java tests/system/src/testscriptapp2/resources/mymod/myapp2/demo_02_off.fxml tests/system/src/testscriptapp2/java/mymod/myapp2/FXMLScriptDeployment2Compile_Off_On.java tests/system/src/testscriptapp2/resources/mymod/myapp2/demo_02_off_on.fxml tests/system/src/testscriptapp2/java/mymod/myapp2/FXMLScriptDeployment2Compile_On.java tests/system/src/testscriptapp2/resources/mymod/myapp2/demo_02_on.fxml tests/system/src/testscriptapp2/java/mymod/myapp2/FXMLScriptDeployment2Compile_On_Off.java tests/system/src/testscriptapp2/resources/mymod/myapp2/demo_02_on_off.fxml |
This WIP adds a "compile" process instruction ("") to fxml files with the optional PI data "true" (default) and "false". The PI data is turned into a boolean value using "Boolean.parseBoolean(String)".
This makes it possible to inject the compile PI everywhere in a FXML file and turn on and off compilation of scripts if the scripting engine implements the javax.script.Compilable interface.
This version builds upon #129.
Progress
Download
$ git fetch https://git.openjdk.java.net/jfx pull/187/head:pull/187
$ git checkout pull/187