Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8208169: can not print selected pages of web page #222

Closed
wants to merge 5 commits into from
Closed

8208169: can not print selected pages of web page #222

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3974892
8208169: can not print selected pages of web page
May 15, 2020
75a0362
added manual test
Jun 1, 2020
4d973a3
Replaced webpage with locally generated html content in test
Jun 14, 2020
717dac0
cleanup unused variable
Jun 15, 2020
456d0a1
Formatting changes
Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 19 additions & 4 deletions modules/javafx.web/src/main/java/javafx/scene/web/WebEngine.java
View file
Open in desktop
Expand Up @@ -48,7 +48,9 @@
import javafx.event.EventHandler;
import javafx.event.EventType;
import javafx.geometry.Rectangle2D;
import javafx.print.JobSettings;
import javafx.print.PageLayout;
import javafx.print.PageRange;
import javafx.print.PrinterJob;
import javafx.scene.Node;
import javafx.util.Callback;
Expand Down Expand Up @@ -1609,10 +1611,23 @@ public void print(PrinterJob job) {
float height = (float) pl.getPrintableHeight();
int pageCount = page.beginPrinting(width, height);

for (int i = 0; i < pageCount; i++) {
if (printStatusOK(job)) {
Node printable = new Printable(page, i, width);
job.printPage(printable);
JobSettings jobSettings = job.getJobSettings();
if(jobSettings.getPageRanges() != null) {
bhaweshkc marked this conversation as resolved.
Show resolved Hide resolved
PageRange[] pageRanges = jobSettings.getPageRanges();
for (PageRange p : pageRanges) {
for (int i = p.getStartPage(); i <= p.getEndPage() && i <= pageCount; ++i) {
if (printStatusOK(job)) {
Node printable = new Printable(page, i - 1, width);
job.printPage(printable);
}
}
}
} else {
for (int i = 0; i < pageCount; i++) {
if (printStatusOK(job)) {
Node printable = new Printable(page, i, width);
job.printPage(printable);
}
}
}
page.endPrinting();
Expand Down