Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8265031: Change default macOS min version for x86_64 to 10.12 and aarch64 to 11.0 #462

Closed
wants to merge 2 commits into from
Closed

8265031: Change default macOS min version for x86_64 to 10.12 and aarch64 to 11.0 #462

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
218459e
8265031: Change default macOS min version for x86_64 to 10.12 and aar…
kevinrushforth Apr 12, 2021
8980ab6
update to use isAarch64 per review comments
kevinrushforth Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion buildSrc/mac.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ def defaultSdkPath = "/Applications/Xcode.app/Contents/Developer/Platforms/MacOS

// Set the minimum API version that we require (developers do not need to override this)
// Note that this is not necessarily the same as the preferred SDK version
defineProperty("MACOSX_MIN_VERSION", "10.10");
def isAarch64 = TARGET_ARCH == "aarch64" || TARGET_ARCH == "arm64";
def macOSMinVersion = (TARGET_ARCH == "aarch64" || TARGET_ARCH == "arm64") ? "11.0" : "10.12";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess isAarch64 was defined to use on line 59 in ternary operator.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

defineProperty("MACOSX_MIN_VERSION", macOSMinVersion);

// Create $buildDir/mac_tools.properties file and load props from it
setupTools("mac_tools",
Expand Down