-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8234471: Canvas in webview displayed with wrong scale on Windows #62
Conversation
👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into |
Webrevs
|
have you tested this on Linux and Mac by changing JVM option -Dglass.win.uiScale=. |
/reviewers 2 |
@kevinrushforth |
This looks like the correct fix, and I can confirm that it does fix the problem. I'll run a set of regression tests on Windows 10 with 125% scaling (which is my normal environment) and then finish my review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks good to me. I left one comment on the test.
tests/system/src/test/java/test/javafx/scene/web/CanvasTest.java
Outdated
Show resolved
Hide resolved
@arun-joseph This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 98 commits pushed to the As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @guruhb) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@arun-joseph |
/sponsor |
@kevinrushforth @arun-joseph The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit f3a3ea0. |
This bug can be reproduced when the screen resolution is at 125%, 150% and 175% for Windows, which correpsonds to
pixelScale
values of 1.25, 1.5 and 1.75, respectively.Issue: The rectangle inside canvas is rendered on
pixelScale
while the borders are rendered onMath.ceil(pixelScale)
Fix: Use
Math.ceil(pixelScale)
for calculatingpixelScaleTransform
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/62/head:pull/62
$ git checkout pull/62