Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266966: Wrong CSS properties are applied to other nodes after fix for JDK-8204568 #17

Closed
wants to merge 1 commit into from

Conversation

@arapte
Copy link
Member

@arapte arapte commented May 18, 2021

Fixes a css style regression issue caused by JDK-8204568.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266966: Wrong CSS properties are applied to other nodes after fix for JDK-8204568

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/17/head:pull/17
$ git checkout pull/17

Update a local copy of the PR:
$ git checkout pull/17
$ git pull https://git.openjdk.java.net/jfx11u pull/17/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17

View PR using the GUI difftool:
$ git pr show -t 17

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/17.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 18, 2021

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 93de5840b19868fbe8850b846418c3f6f72df256 8266966: Wrong CSS properties are applied to other nodes after fix for JDK-8204568 May 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266966: Wrong CSS properties are applied to other nodes after fix for JDK-8204568

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 18, 2021

Webrevs

@arapte
Copy link
Member Author

@arapte arapte commented May 18, 2021

/integrate

@openjdk openjdk bot closed this May 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@arapte Since your change was applied there have been 2 commits pushed to the master branch:

  • 37d25bc: 8257758: Allow building of JavaFX native libs for Apple Silicon
  • d3ba1ce: 8264536: Building OpenJFX on Apple AARCH64 not possible

Your commit was automatically rebased without conflicts.

Pushed as commit b2d930e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant