6996: Properly support converters

[thegreystone]

Including simple test to verify that the resulting instrumented methods are ok.

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	linux	mac	win
Build / test	✔️ (1/1 passed)	✔️ (1/1 passed)	✔️ (1/1 passed)

Issue

• JMC-6996: Properly support converters

Reviewers

• Guru Hb (@guruhb - Reviewer) ⚠️ Review applies to 111b608

Download

$ git fetch https://git.openjdk.java.net/jmc pull/168/head:pull/168
$ git checkout pull/168

[bridgekeeper]

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 09: Full (fafa560)
• 08: Full - Incremental (111b608)
• 07: Full - Incremental (b0de692)
• 06: Full - Incremental (3ffaa3e)
• 05: Full - Incremental (cdd1179)
• 04: Full - Incremental (89f3c91)
• 03: Full - Incremental (4ea8707)
• 02: Full - Incremental (301cd69)
• 01: Full - Incremental (6ad02d7)
• 00: Full (663f3fc)

[thegreystone]

I'll need to do more validation and have better handling of bad configurations, but will handle that in a bug after this enhancement is in.

[gunnarmorling]

A few comments/suggestions inline. Some surely based on my lack of familiarity with the code base, so bear with me ;)

[thegreystone]

Note that this will be changed back by @Josh-Matsuoka once the JDK 8 fixes are in. :)

[gunnarmorling]

Some more small comments.

[guruhb]

Please update README.md

[openjdk]

@thegreystone this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout agentdefaultconverters
git fetch https://git.openjdk.java.net/jmc master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6996: Properly support converters

Reviewed-by: ghb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[thegreystone]

/integrate

[openjdk]

@thegreystone Pushed as commit abfabc3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.