Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7327: Constant Pool optimizations #273

Closed
wants to merge 1 commit into from
Closed

Conversation

@jpbempel
Copy link
Member

@jpbempel jpbempel commented Jul 8, 2021

Fix topic name for Constant pools page. This avoid to have the same
results than the recording ones


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/273/head:pull/273
$ git checkout pull/273

Update a local copy of the PR:
$ git checkout pull/273
$ git pull https://git.openjdk.java.net/jmc pull/273/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 273

View PR using the GUI difftool:
$ git pr show -t 273

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/273.diff

Fix topic name for Constant pools page. This avoid to have the same
results than the recording ones
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 8, 2021

👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 8, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@jpbempel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7327: Constant Pool optimizations

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 8, 2021
@jpbempel
Copy link
Member Author

@jpbempel jpbempel commented Jul 8, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

Going to push as commit f5a9cf3.

@openjdk openjdk bot closed this Jul 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@jpbempel Pushed as commit f5a9cf3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jpbempel jpbempel deleted the 7327 branch Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants