7992: Add API to easily write annotated Java JFR events #457
Conversation
|
👋 Welcome back jbachorik! A progress list of the required criteria for merging this PR into |
thegreystone
changed the title
|
@jbachorik This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Hi Jaroslav! This one is still in draft. Want to get it into JMC 9? |
jbachorik
force-pushed
the
jb/JMC-7992
branch
from
9d96125
to
eecdda8
Compare
Webrevs
|
jbachorik
force-pushed
the
jb/JMC-7992
branch
from
ba0217d
to
a79f83c
Compare
|
@jbachorik Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
@jbachorik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
❗ This change is not yet ready to be integrated. |
|
/rebase |
|
@jbachorik Unknown command |
|
@jbachorik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Please, don't close it, bridgekeeper ;) |
|
@jbachorik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
A gentle ping ... |
|
Hi @jbachorik! Some tests verifying the registering of some subclass of jdk.jfr.Event, and that also have annotations in it, and that creates a few events of it, would be good. |
|
@jbachorik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
| break; | ||
| } | ||
| default: { | ||
| //System.err.println("Cannot write type:" + f.getType().getName()); |
This PR extends the JFR Writer API with the ability to use the custom JFR event types (eg. classes extending
jdk.jfr.Event) and register new writer type for them and also directly accept the instances of those types to write them in the recording.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/457/head:pull/457$ git checkout pull/457Update a local copy of the PR:
$ git checkout pull/457$ git pull https://git.openjdk.org/jmc.git pull/457/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 457View PR using the GUI difftool:
$ git pr show -t 457Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/457.diff
Webrev
Link to Webrev Comment