-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7992: Add API to easily write annotated Java JFR events #457
Conversation
👋 Welcome back jbachorik! A progress list of the required criteria for merging this PR into |
@jbachorik This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi Jaroslav! This one is still in draft. Want to get it into JMC 9? |
9d96125
to
eecdda8
Compare
Webrevs
|
ba0217d
to
a79f83c
Compare
@jbachorik Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
@jbachorik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@jbachorik This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/rebase |
@jbachorik Unknown command |
@jbachorik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Please, don't close it, bridgekeeper ;) |
@jbachorik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
A gentle ping ... |
Hi @jbachorik! Some tests verifying the registering of some subclass of jdk.jfr.Event, and that also have annotations in it, and that creates a few events of it, would be good. |
@jbachorik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
...flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/RecordingImpl.java
Outdated
Show resolved
Hide resolved
@jbachorik, have you had a chance to create that unit test yet? |
@thegreystone Yes, I have extended the |
/integrate |
@jbachorik |
@jbachorik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/sponsor |
@thegreystone @jbachorik Pushed as commit 4c9d9e4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR extends the JFR Writer API with the ability to use the custom JFR event types (eg. classes extending
jdk.jfr.Event
) and register new writer type for them and also directly accept the instances of those types to write them in the recording.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/457/head:pull/457
$ git checkout pull/457
Update a local copy of the PR:
$ git checkout pull/457
$ git pull https://git.openjdk.org/jmc.git pull/457/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 457
View PR using the GUI difftool:
$ git pr show -t 457
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/457.diff
Webrev
Link to Webrev Comment