CODETOOLS-7903109: JMH: perfasm "freq" should accept "max" as the option #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux perf record accepts "max" as the max sampling frequency possible on the system. JMH perfasm should accept it too. Defaulting to "max" is probably counter-productive at this point, because it probably comes with additional profiling overhead.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmh pull/64/head:pull/64
$ git checkout pull/64
Update a local copy of the PR:
$ git checkout pull/64
$ git pull https://git.openjdk.java.net/jmh pull/64/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 64
View PR using the GUI difftool:
$ git pr show -t 64
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmh/pull/64.diff