Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODETOOLS-7903109: JMH: perfasm "freq" should accept "max" as the option #64

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 22, 2022

Linux perf record accepts "max" as the max sampling frequency possible on the system. JMH perfasm should accept it too. Defaulting to "max" is probably counter-productive at this point, because it probably comes with additional profiling overhead.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmh pull/64/head:pull/64
$ git checkout pull/64

Update a local copy of the PR:
$ git checkout pull/64
$ git pull https://git.openjdk.java.net/jmh pull/64/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 64

View PR using the GUI difftool:
$ git pr show -t 64

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmh/pull/64.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 22, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 22, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 22, 2022

Webrevs

@shipilev shipilev merged commit f2ee210 into openjdk:master Feb 23, 2022
@shipilev shipilev deleted the 7903109-perfasm-frequency branch February 23, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
1 participant