Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254879: Implement JNI path for Draw Poly #117

Closed

Conversation

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Oct 16, 2020

When RenderQueueBuffer cant hold all the attributes needed for DrawPoly we pass the content directly to Renderer using JNI. This path is not implemented in metal and looks like we are not hitting this path in our testing in Metal. JNI method is used in common BufferedRenderPipe logic so we need to implement JNI path for Metal.


Progress

  • Change must not contain extraneous whitespace

Testing

Linux x64 Windows x64 macOS x64
Build (3/3 running) (2/2 running) (2/2 running)

Issue

Download

$ git fetch https://git.openjdk.java.net/lanai pull/117/head:pull/117
$ git checkout pull/117

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 16, 2020

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2020

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254879: Implement JNI path for Draw Poly

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Oct 16, 2020
@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Oct 16, 2020

/integrate

@openjdk openjdk bot closed this Oct 16, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2020

@jayathirthrao Pushed as commit febb027.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jayathirthrao jayathirthrao deleted the jayathirthrao:JDK-8254879-jni-drawpoly branch Oct 16, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 16, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant