minor fixes in fill

openjdk · May 13, 2020 · e66ab85 · e66ab85
1 parent f0e10f6
commit e66ab85
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemorySegment.java b/src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemorySegment.java
@@ -207,6 +207,8 @@ static <S extends MemorySegment> Spliterator<S> spliterator(S segment, SequenceL
      * for (long l = 0; l < segment.byteSize(); l++) {
      *     byteHandle.set(segment.baseAddress(), l, value);
      * }</pre></blockquote>
+     * without any regard or guarantees on the ordering of particular memory
+     * elements being set.
      * <p>
      * Fill can be useful to initialize or reset the memory of a segment.
      *

diff --git a/src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java b/src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java
@@ -118,10 +118,7 @@ public static <S extends MemorySegment> Spliterator<S> spliterator(S segment, Se
 
     public static void fill(MemorySegment segment, byte value) {
         AbstractMemorySegmentImpl segmentImpl = (AbstractMemorySegmentImpl) segment;
-        segmentImpl.checkValidState();
-        if (!segmentImpl.isSet(WRITE)) {
-            throw segmentImpl.unsupportedAccessMode(WRITE);
-        }
+        segmentImpl.checkRange(0, segmentImpl.length, true);
         UNSAFE.setMemory(segmentImpl.base(), segmentImpl.min(), segmentImpl.length, value);
     }