8241504: Expose MemoryLayout annotations/attributes in the public API

[JornVernee]

Hi,

This PR exposed MemoryLayout attributes in the public API.

A summary of the changes:

• Renamed annotation -> attribute everywhere to avoid confusion with Java language annotations
• Made sure that annotations were being serialized as part of a MemoryLayout's ConstantDesc, as well as the alignment which was previously left out. (The latter also meant changing PaddingLayout::hasNaturalAlignment to always return true, so serializing alignment is skipped for padding).
• Removed special casing for the abiType attribute. This can now instead be handled through the generic attribute mechanism.

Thanks,
Jorn

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

• ⚠️ Temporary failure when trying to retrieve information on issue 8241504.

Reviewers

• Maurizio Cimadamore (mcimadamore - Committer)

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/64/head:pull/64
$ git checkout pull/64

[bridgekeeper]

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into foreign-abi will be added to the body of your pull request.

[mlbridge]

Webrevs

• 04: Full - Incremental (19e5560)
• 03: Full - Incremental (d3baa35)
• 02: Full - Incremental (380a1b0)
• 01: Full - Incremental (2d58b86)
• 00: Full (e09a98c)

[mcimadamore]

Couple of suggestions, the rest looks really solid.

[JornVernee]

I've also added some very basic tests of the new methods, mostly to sort of document the expectations w.r.t. how NAME is just another attribute, plus how using the attribute(String,Class) overload filters the optional with an instanceof check as opposed to simply casting (and potentially failing that cast with CCE).

[mcimadamore]

Some more comments

[mcimadamore]

Looks good

[openjdk]

@JornVernee This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8241504: Expose MemoryLayout annotations/attributes in the public API

Reviewed-by: mcimadamore

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

[JornVernee]

/integrate

[openjdk]

@JornVernee
Pushed as commit 3eda917.

[mlbridge]

Mailing list message from Jorn Vernee on panama-dev:

Changeset: 3eda917
Author: Jorn Vernee <jvernee at openjdk.org>
Date: 2020-03-26 13:19:18 +0000
URL: https://git.openjdk.java.net/panama-foreign/commit/3eda9176

8241504: Expose MemoryLayout annotations/attributes in the public API

Reviewed-by: mcimadamore

! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/AbstractLayout.java
! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/GroupLayout.java
! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryLayout.java
! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryLayouts.java
! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/PaddingLayout.java
! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/SequenceLayout.java
! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/SystemABI.java
! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/ValueLayout.java
! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/Utils.java
! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/aarch64/CallArranger.java
! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/sysv/CallArranger.java
! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/windows/CallArranger.java
! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/windows/Windowsx64ABI.java
! test/jdk/java/foreign/NativeTestHelper.java
+ test/jdk/java/foreign/TestLayoutAttributes.java
! test/jdk/java/foreign/TestLayoutConstants.java