8241504: Expose MemoryLayout annotations/attributes in the public API (foreign-jextract part)

[JornVernee]

Hi,

These are the jextract changes needed after exposing layout attributes in the public API. This also fixes the pending merge conflict, which was closely related to the needed changes.

Jorn

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

• JDK-8241504: Expose MemoryLayout annotations/attributes in the public API

Reviewers

• Maurizio Cimadamore (mcimadamore - Committer)

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/69/head:pull/69
$ git checkout pull/69

[bridgekeeper]

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (a107472)
• 00: Full (a107472)

[JornVernee]

So, this includes a merge for: #68 and some other jextract fixes. Both are needed to get foreign-jextract building & passing tests again. Just the other changes besides the merge can be seen when looking at the diff for the last commit: a107472

[mcimadamore]

Looks good

[openjdk]

@JornVernee This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8241504: Expose MemoryLayout annotations/attributes in the public API (foreign-jextract part)

Reviewed-by: mcimadamore

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

[JornVernee]

/integrate

[openjdk]

@JornVernee
Pushed as commit f0cd102.

[mlbridge]

Mailing list message from Jorn Vernee on panama-dev:

Changeset: f0cd102
Author: Jorn Vernee <jvernee at openjdk.org>
Date: 2020-03-26 15:52:22 +0000
URL: https://git.openjdk.java.net/panama-foreign/commit/f0cd1026

8241504: Expose MemoryLayout annotations/attributes in the public API (foreign-jextract part)

Reviewed-by: mcimadamore

! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/AbstractLayout.java
! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/GroupLayout.java
! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryLayout.java
! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryLayouts.java
! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/PaddingLayout.java
! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/SequenceLayout.java
! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/SystemABI.java
! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/ValueLayout.java
! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/Utils.java
! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/aarch64/CallArranger.java
! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/sysv/CallArranger.java
! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/windows/CallArranger.java
! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/windows/Windowsx64ABI.java
! src/jdk.incubator.jextract/share/classes/jdk/incubator/jextract/tool/JavaSourceBuilder.java
! src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/Utils.java
! test/jdk/java/foreign/NativeTestHelper.java
+ test/jdk/java/foreign/TestLayoutAttributes.java
! test/jdk/java/foreign/TestLayoutConstants.java
! test/jdk/tools/jextract/JextractToolRunner.java
! test/jdk/tools/jextract/testStruct/LibStructTest.java