Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279344: riscv: RVB: Add bitwise rotation instructions #39

Closed
wants to merge 5 commits into from

Conversation

feilongjiang
Copy link
Member

@feilongjiang feilongjiang commented Dec 31, 2021

This PR implements bitwise instructions of RISC-V BitManipulation Extension, including ror/rolw/ror/rori/roriw/rorw. New C2 instructions are covered by following JTREG tests:

  • test/hotspot/jtreg/compiler/intrinsics/TestRotate.java
  • test/jdk/java/lang

This PR also add zext/sext C2 instructions that were missed in JDK-8279213

Hotspot and jdk tier1 test on QEMU (enable RVB) are passed without new failures.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279344: riscv: RVB: Add bitwise rotation instructions

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/riscv-port pull/39/head:pull/39
$ git checkout pull/39

Update a local copy of the PR:
$ git checkout pull/39
$ git pull https://git.openjdk.java.net/riscv-port pull/39/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 39

View PR using the GUI difftool:
$ git pr show -t 39

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/riscv-port/pull/39.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 31, 2021

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 31, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 31, 2021

@feilongjiang feilongjiang changed the title 8279344: riscv: RVB: Add bitwise rotation instructions 8279344: riscv: RVB: Add bitwise rotation instrucitons Dec 31, 2021
@feilongjiang feilongjiang changed the title 8279344: riscv: RVB: Add bitwise rotation instrucitons 8279344: riscv: RVB: Add bitwise rotation instructions Dec 31, 2021
@feilongjiang feilongjiang force-pushed the rvb-rol-ror branch 2 times, most recently from d327d71 to 428e215 Compare December 31, 2021 09:19
@feilongjiang
Copy link
Member Author

Rebased #40 with no conflicts.

src/hotspot/cpu/riscv/riscv_b.ad Outdated Show resolved Hide resolved
Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@openjdk
Copy link

openjdk bot commented Jan 4, 2022

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279344: riscv: RVB: Add bitwise rotation instructions

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the riscv-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 4, 2022
@feilongjiang
Copy link
Member Author

/integrate

@RealFYang
Copy link
Member

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 4, 2022
@openjdk
Copy link

openjdk bot commented Jan 4, 2022

@feilongjiang
Your change (at version d4e74d5) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Jan 4, 2022

Going to push as commit c1c0833.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 4, 2022
@openjdk openjdk bot closed this Jan 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 4, 2022
@openjdk
Copy link

openjdk bot commented Jan 4, 2022

@RealFYang @feilongjiang Pushed as commit c1c0833.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@feilongjiang feilongjiang deleted the rvb-rol-ror branch January 4, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants