8279346: riscv: Unnecessary sign extension in BigInteger intrinsics

[yhzhu20]

Reference: https://github.com/riscv-non-isa/riscv-elf-psabi-doc

" Scalars that are at most XLEN bits wide are passed in a single argument register, or on the stack by value if none is available.
When passed in registers or on the stack, integer scalars narrower than XLEN bits are widened according to the sign of their type up to 32 bits, then sign-extended to XLEN bits.
When passed in registers or on the stack, floating-point types narrower than XLEN bits are widened to XLEN bits, with the upper bits undefined."

So there is no need to do sign extension for signed integer input parameters.

Performed full jtreg tests with qemu without new failures.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8279346: riscv: Unnecessary sign extension in BigInteger intrinsics

Reviewers

• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/riscv-port pull/40/head:pull/40
$ git checkout pull/40

Update a local copy of the PR:
$ git checkout pull/40
$ git pull https://git.openjdk.java.net/riscv-port pull/40/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 40

View PR using the GUI difftool:
$ git pr show -t 40

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/riscv-port/pull/40.diff

[bridgekeeper]

👋 Welcome back yzhu! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (27d474e9)

[RealFYang]

Looks good.

[openjdk]

@yhzhu20 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279346: riscv: Unnecessary sign extension in BigInteger intrinsics

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the riscv-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[yhzhu20]

/integrate

[RealFYang]

/sponsor

[openjdk]

@yhzhu20
Your change (at version 27d474e) is now ready to be sponsored by a Committer.

[openjdk]

Going to push as commit e73db5d.

[openjdk]

@RealFYang @yhzhu20 Pushed as commit e73db5d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.