Add --no-token flag

openjdk · Nov 26, 2019 · ac5efe8 · ac5efe8
1 parent dab55bd
commit ac5efe8
Showing 1 changed file with 23 additions and 4 deletions.
diff --git a/cli/src/main/java/org/openjdk/skara/cli/GitPr.java b/cli/src/main/java/org/openjdk/skara/cli/GitPr.java
@@ -255,6 +255,10 @@ public static void main(String[] args) throws IOException, InterruptedException
                   .fullname("no-decoration")
                   .helptext("Hide any decorations when listing PRs")
                   .optional(),
+            Switch.shortcut("")
+                  .fullname("no-token")
+                  .helptext("Do not use a personal access token (PAT). Only works for read-only operations.")
+                  .optional(),
             Switch.shortcut("")
                   .fullname("mercurial")
                   .helptext("Force use of Mercurial (hg)")
@@ -306,21 +310,36 @@ public static void main(String[] args) throws IOException, InterruptedException
         var username = arguments.contains("username") ? arguments.get("username").asString() : null;
         var token = isMercurial ? System.getenv("HG_TOKEN") :  System.getenv("GIT_TOKEN");
         var uri = Remote.toWebURI(remotePullPath);
-        var action = arguments.at(0).asString();
-        var isReadOnly = List.of("list", "fetch", "show", "checkout", "apply").contains(action);
-        var credentials = isReadOnly ?
+        var shouldUseToken = !arguments.contains("no-token");
+        var credentials = !shouldUseToken ?
             null :
             GitCredentials.fill(uri.getHost(), uri.getPath(), username, token, uri.getScheme());
         var forgeURI = URI.create(uri.getScheme() + "://" + uri.getHost());
         var forge = credentials == null ?
             Forge.from(forgeURI) :
             Forge.from(forgeURI, new Credential(credentials.username(), credentials.password()));
         if (forge.isEmpty() || !forge.get().isValid()) {
+            if (!shouldUseToken) {
+                if (arguments.contains("verbose")) {
+                    System.err.println("");
+                }
+                System.err.println("warning: using git-pr with --no-token may result in rate limiting from " + forgeURI);
+                if (!arguments.contains("verbose")) {
+                    System.err.println("         Re-run git-pr with --verbose to see if you are being rate limited");
+                    System.err.println("");
+                }
+            }
             exit("error: failed to connect to host: " + forgeURI);
         }
-
         var host = forge.get();
 
+        var action = arguments.at(0).asString();
+        if (!shouldUseToken &&
+            !List.of("list", "fetch", "show", "checkout", "apply").contains(action)) {
+            System.err.println("error: --no-token can only be used with read-only operations");
+            System.exit(1);
+        }
+
         if (action.equals("create")) {
             if (isMercurial) {
                 var currentBookmark = repo.currentBookmark();