Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr: add /tag commit command #1056

Closed
wants to merge 1 commit into from
Closed

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Mar 15, 2021

Hi all,

please review this patch that adds the /tag commit command. As the name implies, the command is used to create a tag with the given name referring to the commit the command is applied to. The command will check that the tag isn't already used and that it conforms to an eventual .jcheck/conf configuration.

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/1056/head:pull/1056
$ git checkout pull/1056

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 15, 2021

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 15, 2021

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Mar 15, 2021

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

pr: add /tag commit command

Reviewed-by: rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 15, 2021
@edvbld
Copy link
Member Author

@edvbld edvbld commented Mar 15, 2021

/integrate

@openjdk openjdk bot closed this Mar 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 15, 2021

@edvbld Pushed as commit 0b326a6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Mar 15, 2021

Will a project be able to configure the role / review requirements for adding a tag? For example, I can imagine that some projects might want to allow a Reviewer to add a tag without needing review approval from another Reviewer.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 15, 2021

Mailing list message from Magnus Ihse Bursie on skara-dev:

On 2021-03-15 14:13, Kevin Rushforth wrote:

On Mon, 15 Mar 2021 09:13:24 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

Hi all,

please review this patch that adds the `/tag` commit command. As the name implies, the command is used to create a tag with the given name referring to the commit the command is applied to. The command will check that the tag isn't already used and that it conforms to an eventual `.jcheck/conf` configuration.

Thanks,
Erik
Looks good!
Will a project be able to configure the role / review requirements for adding a tag? For example, I can imagine that some projects might want to allow a Reviewer to add a tag without needing review approval from another Reviewer.

Tagging has never required review approval, now, has it? I thought
integrator just applied tags for builds, basically on their own discretion.

So my question is basically the opposite: are there projects where
tagging *should* require a review procedure?

/Magnus

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Mar 15, 2021

So my question is basically the opposite: are there projects where tagging should require a review procedure?

Probably not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants