Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17: Review comments not reflected on mailing lists #11

Closed
wants to merge 2 commits into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Jun 28, 2019

Hi all,

Please review the following change that adds support for comments attached to reviews. This is not supported by GitLab CE, but is used by GitHub.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added bots rfr labels Jun 28, 2019
@mlbridge
Copy link

mlbridge bot commented Jun 28, 2019

Webrevs

@edvbld
Copy link
Member

edvbld commented Jun 28, 2019

Ehm, small patch 😄 Did you run the integrations tests for GitLab CE and GitHub to test this?

@rwestberg
Copy link
Member Author

rwestberg commented Jul 1, 2019

😊 there were actually a few GitLab CE tests failing, fixed now.

@edvbld
edvbld approved these changes Jul 1, 2019
Copy link
Member

edvbld left a comment

Looks good

@openjdk openjdk bot removed the rfr label Jul 1, 2019
@openjdk
Copy link

openjdk bot commented Jul 1, 2019

This PR has been reviewed by Erik Helin (ehelin - Reviewer) - changes are approved.

@openjdk
Copy link

openjdk bot commented Jul 1, 2019

@rwestberg This change can now be integrated. The commit message will be:

17: Review comments not reflected on mailing lists

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

  • 68e0bee: 29: ModulePlugin removes compiler options
  • 3bdfd34: 28: JSON parser does not support empty objects or arrays with whitespace
  • d29c19e: Check if census endpoint is a URL before trying to parse it as a path.

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Jul 1, 2019
@rwestberg
Copy link
Member Author

rwestberg commented Jul 1, 2019

/integrate

@openjdk openjdk bot closed this Jul 1, 2019
@openjdk
Copy link

openjdk bot commented Jul 1, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 3565522.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.