17: Review comments not reflected on mailing lists

[rwestberg]

Hi all,

Please review the following change that adds support for comments attached to reviews. This is not supported by GitLab CE, but is used by GitHub.

Best regards,
Robin

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Approvers

• Erik Helin (ehelin - Reviewer)

[bridgekeeper]

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

[mlbridge]

Webrevs

• 01: Full - Incremental (5279806)
• 00: Full (5c9c290)

[edvbld]

Ehm, small patch 😄 Did you run the integrations tests for GitLab CE and GitHub to test this?

[rwestberg]

😊 there were actually a few GitLab CE tests failing, fixed now.

[edvbld]

Looks good

[openjdk]

This PR has been reviewed by Erik Helin (ehelin - Reviewer) - changes are approved.

[openjdk]

@rwestberg This change can now be integrated. The commit message will be:

17: Review comments not reflected on mailing lists

Reviewed-by: ehelin

• If you would like to add a summary, use the /summary command.
• To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

• 68e0bee: 29: ModulePlugin removes compiler options
• 3bdfd34: 28: JSON parser does not support empty objects or arrays with whitespace
• d29c19e: Check if census endpoint is a URL before trying to parse it as a path.

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

• To integrate this PR with the above commit message, type /integrate in a new comment.

[rwestberg]

/integrate

[openjdk]

@rwestberg The following commits have been pushed to master since your change was applied:

• 68e0bee
• 3bdfd34
• d29c19e

Your commit was automatically rebased without conflicts.
Pushed as commit 3565522.