Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

997: Email notifications are not sent to alias if binary change is commented in Gitlab #1190

Closed
wants to merge 2 commits into from
Closed

997: Email notifications are not sent to alias if binary change is commented in Gitlab #1190

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a04129
SKARA-997
erikj79 Jun 16, 2021
6a22c75
Clarified comment
erikj79 Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,8 @@ private ReviewComment parseReviewComment(String discussionId, ReviewComment pare

var position = note.get("position");
// Is this a line comment?
// For line comments, this field is always set, either to a value or null, but
// for file comments there is no new_line field at all.
if (position.get("new_line") != null) {
// Is the comment on the old or the new version of the file?
if (position.get("new_line").isNull()) {
Expand Down