Add --no-token flag to git-pr

[edvbld]

Hi all,

please review this pull request that adds a --no-token flag to git-pr. This is useful for those merely wanting to try out the read-only operations of git-pr (such as git pr list or git pr show) or for those that do not want to create a personal access token (PAT). The downside for not using a token for read-only operations is that GitHub quite aggressively rate limits the number of REST API HTTP operations (seems like 60 REST API HTTP operations per minute at the moment).

Thanks,
Erik

Testing

• Manual testing of various git-pr subcommands

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Approvers

• Robin Westberg (rwestberg - Reviewer) Note! Review applies to ac5efe8

[bridgekeeper]

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

[mlbridge]

Webrevs

• 01: Full (bb34d4b)
• 00: Full (ac5efe8)

[edvbld]

Robin please note that this patch also makes some changes to GitHubHost.java, GitHubRepository.java and how those classes handle the installation token (I also cleaned up an old test that didn't require a token).

[rwestberg]

Looks good! Perhaps a typo, but the anonymous rate limit is actually 60 requests per hour (not minute) so even worse. :)

[openjdk]

@edvbld This change can now be integrated. The commit message will be:

Add --no-token flag to git-pr

Reviewed-by: rwestberg

• If you would like to add a summary, use the /summary command.
• To list additional contributors, use the /contributor command.
• To integrate this PR with the above commit message, type /integrate in a new comment.

[edvbld]

/integrate

[openjdk]

@edvbld
Pushed as commit 5c3f278.

[mlbridge]

Mailing list message from Erik Helin on skara-dev:

Changeset: 5c3f278
Author: Erik Helin
Date: 2019-11-26 12:32:27 +0000
URL: https://git.openjdk.java.net/skara/commit/5c3f278d

Add --no-token flag to git-pr

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java
! forge/src/main/java/org/openjdk/skara/forge/github/GitHubHost.java
! forge/src/main/java/org/openjdk/skara/forge/github/GitHubRepository.java
! forge/src/test/java/org/openjdk/skara/forge/github/GitHubHostTests.java