Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

234: Allow more granular jcheck reviewer configuration #368

Closed
wants to merge 2 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jan 20, 2020

Hi all,

please review this patch that allows for more granular reviewers configuration
with jcheck. With this patch a project can now specify exactly how many
reviewers are need for each role, for example:

[checks "reviewer"]
reviewer = 1
committer = 1
author = 1

The above configuration would require three reviewers in total, out of which one
must be reviewer, one must be committer and one must be author. This granularity
of configuration is needed to fully implement PR 364.

I made sure that the patch is backwards compatible, we still support the old
configuration syntax:

[checks "reviewer"]
minimum = 1
role = reviewer

The above will simply be translated to the following configuration:

[checks "reviewer"]
reviewer = 1

Thanks,
Erik

Testing

  • Added a number of additional unit tests

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-234: Allow more granular jcheck reviewer configuration

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 20, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Jan 20, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 20, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good, thanks for fixing! Only saw one spelling issue.

@openjdk openjdk bot removed the rfr label Jan 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 20, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

234: Allow more granular jcheck reviewer configuration

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

Co-Authored-By: Robin Westberg <robin@westberg.se>
@edvbld
Copy link
Member Author

@edvbld edvbld commented Jan 20, 2020

/integrate

@openjdk openjdk bot closed this Jan 20, 2020
@openjdk openjdk bot added integrated and removed ready labels Jan 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 20, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 3d62e28: Avoid quoting an empty review body
  • 9f56fca: Post the incremental webrev url in the PR comment

Your commit was automatically rebased without conflicts.

Pushed as commit daac177.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 20, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: daac177
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-01-20 15:30:10 +0000
URL: https://git.openjdk.java.net/skara/commit/daac177f

234: Allow more granular jcheck reviewer configuration

Reviewed-by: rwestberg

! .jcheck/conf
! jcheck/src/main/java/org/openjdk/skara/jcheck/JCheckConfiguration.java
! jcheck/src/main/java/org/openjdk/skara/jcheck/ReviewersCheck.java
! jcheck/src/main/java/org/openjdk/skara/jcheck/ReviewersConfiguration.java
! jcheck/src/main/java/org/openjdk/skara/jcheck/TooFewReviewersIssue.java
! jcheck/src/test/java/org/openjdk/skara/jcheck/ReviewersCheckTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants