234: Allow more granular jcheck reviewer configuration

[edvbld]

Hi all,

please review this patch that allows for more granular reviewers configuration
with jcheck. With this patch a project can now specify exactly how many
reviewers are need for each role, for example:

[checks "reviewer"]
reviewer = 1
committer = 1
author = 1

The above configuration would require three reviewers in total, out of which one
must be reviewer, one must be committer and one must be author. This granularity
of configuration is needed to fully implement PR 364.

I made sure that the patch is backwards compatible, we still support the old
configuration syntax:

[checks "reviewer"]
minimum = 1
role = reviewer

The above will simply be translated to the following configuration:

[checks "reviewer"]
reviewer = 1

Thanks,
Erik

Testing

• Added a number of additional unit tests

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

SKARA-234: Allow more granular jcheck reviewer configuration

Approvers

• Robin Westberg (rwestberg - Reviewer) Note! Review applies to 7ce157a

[bridgekeeper]

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

[mlbridge]

Webrevs

• 01: Full - Incremental (c4d582c)
• 00: Full (7ce157a)

[rwestberg]

Looks good, thanks for fixing! Only saw one spelling issue.

[openjdk]

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

234: Allow more granular jcheck reviewer configuration

Reviewed-by: rwestberg

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

[edvbld]

/integrate

[openjdk]

@edvbld The following commits have been pushed to master since your change was applied:

• 3d62e28: Avoid quoting an empty review body
• 9f56fca: Post the incremental webrev url in the PR comment

Your commit was automatically rebased without conflicts.

Pushed as commit daac177.

[mlbridge]

Mailing list message from Erik Helin on skara-dev:

Changeset: daac177
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-01-20 15:30:10 +0000
URL: https://git.openjdk.java.net/skara/commit/daac177f

234: Allow more granular jcheck reviewer configuration

Reviewed-by: rwestberg

! .jcheck/conf
! jcheck/src/main/java/org/openjdk/skara/jcheck/JCheckConfiguration.java
! jcheck/src/main/java/org/openjdk/skara/jcheck/ReviewersCheck.java
! jcheck/src/main/java/org/openjdk/skara/jcheck/ReviewersConfiguration.java
! jcheck/src/main/java/org/openjdk/skara/jcheck/TooFewReviewersIssue.java
! jcheck/src/test/java/org/openjdk/skara/jcheck/ReviewersCheckTests.java