273: PR bot should check for empty pull request body

[rwestberg]

Hi all,

Please review this change that makes empty PR bodies fail jcheck, in order to improve the mailing list bridge experience.

Best regards,
Robin

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

• SKARA-273: PR bot should check for empty pull request body

Reviewers

• Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/445/head:pull/445
$ git checkout pull/445

[bridgekeeper]

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 01: Full (4bee776)
• 00: Full (3fbd064)

[edvbld]

Looks good, just two minor comments on the error message!

[edvbld]

Looks good!

[openjdk]

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

273: PR bot should check for empty pull request body

Reviewed-by: ehelin

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 726cd95c0e33446da1f59c3166558f6a581090f4.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

[rwestberg]

/integrate

[openjdk]

@rwestberg The following commits have been pushed to master since your change was applied:

• 726cd95: Add missing newline to PR progress body
• 88db8fa: csr bot: use pull request cache
• e4673d6: webrev: check that issue linker is not null

Your commit was automatically rebased without conflicts.

Pushed as commit 6632a9f.

[mlbridge]

Mailing list message from Robin Westberg on skara-dev:

Changeset: 6632a9f
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-02-18 15:16:54 +0000
URL: https://git.openjdk.java.net/skara/commit/6632a9f1

273: PR bot should check for empty pull request body

Reviewed-by: ehelin

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java
! test/src/main/java/org/openjdk/skara/test/HostCredentials.java