Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry the mbox push action a few times in case of concurrent updates #450

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Feb 18, 2020

Hi all,

Please review this small change that retries the mbox push action a few times, to avoid errors when there are concurrent updates (to unrelated mboxes). Also performs a rebase action if needed to decrease the chance of an error.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 18, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

mlbridge bot commented Feb 18, 2020

Webrevs

Copy link
Member

@edvbld edvbld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing!

@openjdk
Copy link

openjdk bot commented Feb 18, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Retry the mbox push action a few times in case of concurrent updates

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 5c2736f04e4b4179311532cd983f19e5e410eeaa.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 18, 2020
@rwestberg
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Feb 18, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 18, 2020
@openjdk
Copy link

openjdk bot commented Feb 18, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 5c2736f: git-pr: rename "update" to "set"
  • 84a1235: Add checkout instructions to PR body

Your commit was automatically rebased without conflicts.

Pushed as commit cdb7dd4.

@mlbridge
Copy link

mlbridge bot commented Feb 18, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: cdb7dd4
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-02-18 13:27:00 +0000
URL: https://git.openjdk.java.net/skara/commit/cdb7dd43

Retry the mbox push action a few times in case of concurrent updates

Reviewed-by: ehelin

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants