Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper detection of legacy integration comment #609

Closed

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Apr 28, 2020

Hi all,

Please review this small change that updates the legacy integration pattern to match all forms of previously posted comments.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • J. Duke (duke - no project role)
  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/609/head:pull/609
$ git checkout pull/609

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 28, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

mlbridge bot commented Apr 28, 2020

Webrevs

Copy link

@openjdk-bot openjdk-bot left a comment

Looks good!

edvbld
edvbld approved these changes Apr 28, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Apr 28, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Proper detection of legacy integration comment

Reviewed-by: duke, ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 1a0aaa6: Improve error message for non-authors creating Merge PRs

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 1a0aaa613711a366ee23ddec20f3d73938de6c9a.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 28, 2020
@rwestberg
Copy link
Member Author

rwestberg commented Apr 28, 2020

/integrate

@openjdk openjdk bot closed this Apr 28, 2020
@openjdk openjdk bot added integrated and removed ready labels Apr 28, 2020
@openjdk
Copy link

openjdk bot commented Apr 28, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 1a0aaa6: Improve error message for non-authors creating Merge PRs

Your commit was automatically rebased without conflicts.

Pushed as commit b2ea62e.

@openjdk openjdk bot removed the rfr label Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants