-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper detection of legacy integration comment #609
Conversation
👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there has been 1 commit pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
/integrate |
@rwestberg The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit b2ea62e. |
Hi all,
Please review this small change that updates the legacy integration pattern to match all forms of previously posted comments.
Best regards,
Robin
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/609/head:pull/609
$ git checkout pull/609