Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forge: make HostedCommit extend Commit #899

Closed
wants to merge 1 commit into from
Closed

forge: make HostedCommit extend Commit #899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 4 additions & 53 deletions forge/src/main/java/org/openjdk/skara/forge/HostedCommit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,61 +29,14 @@
import java.time.*;
import java.time.format.*;

public class HostedCommit {
private final CommitMetadata metadata;
private final List<Diff> parentDiffs;
public class HostedCommit extends Commit {
private final URI url;

public HostedCommit(CommitMetadata metadata, List<Diff> parentDiffs, URI url) {
this.metadata = metadata;
this.parentDiffs = parentDiffs;
super(metadata, parentDiffs);
this.url = url;
}

public Hash hash() {
return metadata.hash();
}

public Author author() {
return metadata.author();
}

public Author committer() {
return metadata.committer();
}

public List<String> message() {
return metadata.message();
}

public List<Hash> parents() {
return metadata.parents();
}

public ZonedDateTime authored() {
return metadata.authored();
}

public ZonedDateTime committed() {
return metadata.committed();
}

public boolean isInitialCommit() {
return metadata.isInitialCommit();
}

public boolean isMerge() {
return metadata.isMerge();
}

public int numParents() {
return metadata.numParents();
}

public List<Diff> parentDiffs() {
return parentDiffs;
}

public URI url() {
return url;
}
Expand All @@ -95,7 +48,7 @@ public String toString() {

@Override
public int hashCode() {
return Objects.hash(metadata, url);
return Objects.hash(url);
}

@Override
Expand All @@ -105,8 +58,6 @@ public boolean equals(Object o) {
}

var other = (HostedCommit) o;
return Objects.equals(metadata, other.metadata) &&
Objects.equals(parentDiffs, other.parentDiffs) &&
Objects.equals(url, other.url);
return Objects.equals(url, other.url);
}
}