8244975: [lworld] Investigate if VM can implement Object::hashCode by calling ValueBootstrapMethods for inline types

[MrSimms]

Use ValueBootstrapMethods for Object::hashCode()

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8244975: [lworld] Investigate if VM can implement Object::hashCode by calling ValueBootstrapMethods for inline types

Reviewers

• Srikanth Adayapalam (sadayapalam - Committer) ⚠️ Review applies to c9f96b1
• Mandy Chung (mchung - Committer)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/136/head:pull/136
$ git checkout pull/136

[bridgekeeper]

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

[openjdk]

@MrSimms This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8244975: [lworld] Investigate if VM can implement Object::hashCode by calling ValueBootstrapMethods for inline types

Reviewed-by: sadayapalam, mchung

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 5 commits pushed to the lworld branch:

• 67a019a: [lworld] clean up VarHandle support for inline type
• 59d8f6b: 8251046: [lworld] [lw3] C1 should avoid heap allocations in withfield when possible
• 660aa19: 8251107: [lworld] test lworld-values/TopInterfaceNegativeTest.java is failing
• 349b22a: 8251116: [lworld] test lworld-values/ValuesAsRefs.java failing.
• f7f6929: 8250877: [lworld] Remove special acmp handling for isSubstitutable0 method in the JIT

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate 67a019a56d4770bad226e400c228181330400c02.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 04: Full - Incremental (37cdaed)
• 03: Full - Incremental (bef769e)
• 02: Full - Incremental (c9f96b1)
• 01: Full - Incremental (79e9cbc)
• 00: Full (302cad6)

[sadayapalam]

+1 for javac changes, assuming tests are all green

[sadayapalam]

There will be follow on work taken up independently for JDK-8244560 - There is still some discussion that needs to happen for the right behavior when an inline type also happens to be a record, but that can be tackled separately as a javac work item

[MrSimms]

+1 for javac changes, assuming tests are all green

Looks like I did break something:
ValueModifierTest.java:16:28: compiler.err.override.meth: (compiler.misc.cant.override: toString(), compiler.misc.anonymous.class: ValueModifierTest$3, toString(), value), final

rather than .out file:

ValueModifierTest.java:16:28: compiler.err.override.meth: (compiler.misc.cant.override: hashCode(), compiler.misc.anonymous.class: ValueModifierTest$3, hashCode(), value), final

Not sure I completely understand the test...ahh, yeah I do, no longer generate hashCode, but toString was

[mlchung]

This looks good to me. I made a small clean up on javac Gen::synthesizeValueMethod method to remove the switch statement.

[mlchung]

approved

[MrSimms]

/integrate

[openjdk]

@MrSimms The following commits have been pushed to lworld since your change was applied:

• 67a019a: [lworld] clean up VarHandle support for inline type
• 59d8f6b: 8251046: [lworld] [lw3] C1 should avoid heap allocations in withfield when possible
• 660aa19: 8251107: [lworld] test lworld-values/TopInterfaceNegativeTest.java is failing
• 349b22a: 8251116: [lworld] test lworld-values/ValuesAsRefs.java failing.
• f7f6929: 8250877: [lworld] Remove special acmp handling for isSubstitutable0 method in the JIT

Your commit was automatically rebased without conflicts.

Pushed as commit f891f43.