Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252650: [lworld] Merge of jdk-16+8 breaks debug build GC gc/TestObjectAlignment.java #172

Closed
wants to merge 1 commit into from

Conversation

@MrSimms
Copy link
Member

@MrSimms MrSimms commented Sep 1, 2020

Apply in advance: 8251118: BiasedLocking::preserve_marks should not have a HandleMark


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8252650: [lworld] Merge of jdk-16+8 breaks debug build GC gc/TestObjectAlignment.java

Reviewers

  • Harold Seigel (hseigel - Committer)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/172/head:pull/172
$ git checkout pull/172

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 1, 2020

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2020

@MrSimms This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252650: [lworld] Merge of jdk-16+8 breaks debug build GC gc/TestObjectAlignment.java

Reviewed-by: hseigel
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate aada81b02f8099340e2fefadb076799654bb201a.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 1, 2020

Webrevs

hseigel
hseigel approved these changes Sep 1, 2020
@hseigel
Copy link
Member

@hseigel hseigel commented Sep 1, 2020

Changes look good!

@MrSimms
Copy link
Member Author

@MrSimms MrSimms commented Sep 1, 2020

/integrate

@openjdk openjdk bot closed this Sep 1, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 1, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2020

@MrSimms
Pushed as commit 0d8d8e3.

@MrSimms MrSimms deleted the 8252650 branch Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants