Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253047: [lworld] C2 compilation fails with guarantee(sect->end() <= sect->limit()) failed: sanity #186

Closed
wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Sep 11, 2020

We run out of space in C2's scratch buffer when calculating the size of the MachVEPNode because the inline type entry point requires lots of space for the ZGC barriers when the inline type argument contains many object fields.

The fix is to increase the scratch emit buffer size based on the number of oop fields of scalarized inline type arguments.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8253047: [lworld] C2 compilation fails with guarantee(sect->end() <= sect->limit()) failed: sanity

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/186/head:pull/186
$ git checkout pull/186

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 11, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 11, 2020

@TobiHartmann This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253047: [lworld] C2 compilation fails with guarantee(sect->end() <= sect->limit()) failed: sanity
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate dee85cee6aa780987156ac957033dce40b2a4ea7.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Sep 11, 2020

Webrevs

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Sep 11, 2020

/integrate

@openjdk openjdk bot closed this Sep 11, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 11, 2020
@openjdk
Copy link

openjdk bot commented Sep 11, 2020

@TobiHartmann Pushed as commit 74a8523.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant