Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258412: [lworld] TestArrays::test73 fails due to unexpected result #303

Closed
wants to merge 1 commit into from

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Dec 15, 2020

TestArrays::test73 spuriously failed (only) with a product build. I finally figured out that with a product build the -XX:-MonomorphicArrayCheck flag specified by the test is ignored which is required to trigger the problem. Instead of adding yet another scenario to our tests, I've added a PreferCommandLineFlags option to the framework to allow overwriting scenario flags by flags set via the command line. I'll use it for testing some more flag combinations in the CI.

The root cause of the issue is that for a flat array store the MonomorphicArrayCheck optimization updates the array type to the exact (flat) type but does not update the corresponding element type. As a result, elemtype->inline_klass()->is_empty() returns true in product leading to incorrect execution and hits an assert in debug because elemtype is general java.lang.Object.

I've also fixed another issue in Parse::array_store_check() and added some asserts to catch similar issues earlier in the future.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8258412: [lworld] TestArrays::test73 fails due to unexpected result

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/303/head:pull/303
$ git checkout pull/303

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 15, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2020

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258412: [lworld] TestArrays::test73 fails due to unexpected result

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 15, 2020

Webrevs

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Dec 16, 2020

/integrate

@openjdk openjdk bot closed this Dec 16, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2020

@TobiHartmann Pushed as commit 56ddef2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant