-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8266586: [lworld] [lw3] Remove experimental support for primitive classes in JPDA #404
Conversation
👋 Welcome back fparain! A progress list of the required criteria for merging this PR into |
@fparain This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@fparain this pull request can not be integrated into git checkout jpda_cleanup
git fetch https://git.openjdk.java.net/valhalla lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push |
Thank you for the review. Fred |
/integrate |
Remove experimental support for primitive classes in Java debugger in anticipation of a merge with mainline.
At some point the whole JPDA (JDI/JDWP/JVMTI) will have to be updated (specifications and implementations) to fully support primitive classes.
Regards,
Fred
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/404/head:pull/404
$ git checkout pull/404
Update a local copy of the PR:
$ git checkout pull/404
$ git pull https://git.openjdk.java.net/valhalla pull/404/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 404
View PR using the GUI difftool:
$ git pr show -t 404
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/404.diff