Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266586: [lworld] [lw3] Remove experimental support for primitive classes in JPDA #404

Closed
wants to merge 4 commits into from

Conversation

fparain
Copy link
Collaborator

@fparain fparain commented May 6, 2021

Remove experimental support for primitive classes in Java debugger in anticipation of a merge with mainline.
At some point the whole JPDA (JDI/JDWP/JVMTI) will have to be updated (specifications and implementations) to fully support primitive classes.

Regards,

Fred


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8266586: [lworld] [lw3] Remove experimental support for primitive classes in JPDA

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/404/head:pull/404
$ git checkout pull/404

Update a local copy of the PR:
$ git checkout pull/404
$ git pull https://git.openjdk.java.net/valhalla pull/404/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 404

View PR using the GUI difftool:
$ git pr show -t 404

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/404.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2021

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 6, 2021

@fparain This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266586: [lworld] [lw3] Remove experimental support for primitive classes in JPDA

Reviewed-by: dsimms

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented May 6, 2021

Webrevs

Copy link
Member

@MrSimms MrSimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@openjdk
Copy link

openjdk bot commented May 6, 2021

@fparain this pull request can not be integrated into lworld due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout jpda_cleanup
git fetch https://git.openjdk.java.net/valhalla lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push

@openjdk openjdk bot added merge-conflict and removed ready labels May 6, 2021
@openjdk openjdk bot added ready and removed merge-conflict labels May 6, 2021
@fparain
Copy link
Collaborator Author

fparain commented May 6, 2021

Thank you for the review.

Fred

@fparain
Copy link
Collaborator Author

fparain commented May 6, 2021

/integrate

@openjdk openjdk bot closed this May 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 6, 2021
@openjdk
Copy link

openjdk bot commented May 6, 2021

@fparain Pushed as commit ab997be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@fparain fparain deleted the jpda_cleanup branch July 22, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants