-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8270477: [lworld] bytecode testing API does not emit Q type descriptors #552
Conversation
👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into |
@MrSimms This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me.
/integrate |
Going to push as commit e075eaf.
Your commit was automatically rebased without conflicts. |
Fixed bytecodes that need to emit full type descriptors (with their "envelopes") for Q-types
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/552/head:pull/552
$ git checkout pull/552
Update a local copy of the PR:
$ git checkout pull/552
$ git pull https://git.openjdk.java.net/valhalla pull/552/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 552
View PR using the GUI difftool:
$ git pr show -t 552
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/552.diff