Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270477: [lworld] bytecode testing API does not emit Q type descriptors #552

Closed
wants to merge 1 commit into from

Conversation

@MrSimms
Copy link
Member

@MrSimms MrSimms commented Sep 13, 2021

Fixed bytecodes that need to emit full type descriptors (with their "envelopes") for Q-types


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8270477: [lworld] bytecode testing API does not emit Q type descriptors

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/552/head:pull/552
$ git checkout pull/552

Update a local copy of the PR:
$ git checkout pull/552
$ git pull https://git.openjdk.java.net/valhalla pull/552/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 552

View PR using the GUI difftool:
$ git pr show -t 552

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/552.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 13, 2021

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

@MrSimms This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270477: [lworld] bytecode testing API does not emit Q type descriptors

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the lworld branch:

  • 0c0c9e1: 8267697: [lworld] [lw3] VM crashes during heap dump if Java heap contains flat arrays
  • 3111124: 8273554: [lworld] Runtime tests should not explicitly set -Xint/-Xcomp

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 13, 2021

Webrevs

Copy link
Member

@mlchung mlchung left a comment

Looks okay to me.

@MrSimms
Copy link
Member Author

@MrSimms MrSimms commented Sep 14, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

Going to push as commit e075eaf.
Since your change was applied there have been 2 commits pushed to the lworld branch:

  • 0c0c9e1: 8267697: [lworld] [lw3] VM crashes during heap dump if Java heap contains flat arrays
  • 3111124: 8273554: [lworld] Runtime tests should not explicitly set -Xint/-Xcomp

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@MrSimms Pushed as commit e075eaf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants