Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8246014: [lworld] [lw3] serviceability/sa/ClhsdbDumpclass.java is failing for a while #60

Closed
wants to merge 1 commit into from

Conversation

fparain
Copy link
Collaborator

@fparain fparain commented May 27, 2020

Please review these changes fixing the HotSpot agent enough so test serviceability/sa/ClhsdbDumpclass.java would stop failing.

Thank you,

Fred


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8246014: [lworld] [lw3] serviceability/sa/ClhsdbDumpclass.java is failing for a while

Reviewers

  • Harold Seigel (hseigel - Committer)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/60/head:pull/60
$ git checkout pull/60

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 27, 2020

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 27, 2020

@fparain This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8246014: [lworld] [lw3] serviceability/sa/ClhsdbDumpclass.java is failing for a while

Reviewed-by: hseigel
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate ed7a00c6f70a264a1cd3445f5496b53543f4a8bf.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 27, 2020

Webrevs

Copy link
Member

@hseigel hseigel left a comment

Looks good.

@fparain
Copy link
Collaborator Author

@fparain fparain commented May 27, 2020

Thank you Harold.

@fparain
Copy link
Collaborator Author

@fparain fparain commented May 27, 2020

/integrate

@openjdk openjdk bot closed this May 27, 2020
@openjdk openjdk bot added integrated and removed ready labels May 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 27, 2020

@fparain
Pushed as commit 3dee5f5.

@openjdk openjdk bot removed the rfr label May 27, 2020
@fparain fparain deleted the agent_class_dump branch Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants