Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: An R Companion for Introduction to Data Mining #212

Closed
whedon opened this issue Jun 6, 2023 · 52 comments
Closed

[PRE REVIEW]: An R Companion for Introduction to Data Mining #212

whedon opened this issue Jun 6, 2023 · 52 comments

Comments

@whedon
Copy link

whedon commented Jun 6, 2023

Submitting author: @mhahsler (Michael Hahsler)
Repository: https://github.com/mhahsler/Introduction_to_Data_Mining_R_Examples
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @stats-tgeorge
Reviewers: @hughshanahan, @rudeboybert
Managing EiC: Lorena Barba

Status

status

Status badge code:

HTML: <a href="https://jose.theoj.org/papers/1c21e289cb9c887b65cb58740f947f07"><img src="https://jose.theoj.org/papers/1c21e289cb9c887b65cb58740f947f07/status.svg"></a>
Markdown: [![status](https://jose.theoj.org/papers/1c21e289cb9c887b65cb58740f947f07/status.svg)](https://jose.theoj.org/papers/1c21e289cb9c887b65cb58740f947f07)

Author instructions

Thanks for submitting your paper to JOSE @mhahsler. Currently, there isn't an JOSE editor assigned to your paper.

@mhahsler if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSE and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSE submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jun 6, 2023

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSE reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode".

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 6, 2023

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.01686 is OK
- 10.18637/jss.v091.i01 is OK
- 10.18637/jss.v025.i03 is OK
- 10.32614/RJ-2017-047 is OK
- 10.18637/jss.v028.i05 is OK

MISSING DOIs

- 10.1002/0471687545.ch1 may be a valid DOI for title: Introduction to Data Mining

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Jun 6, 2023

Wordcount for paper.md is 532

@whedon
Copy link
Author

whedon commented Jun 6, 2023

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=1.20 s (56.9 files/s, 22896.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            19            695             45          11519
JavaScript                      17            852           1220           6172
Rmd                              9           1116           2249           1284
CSS                             10             96             81            856
TeX                              3             81              0            665
SVG                              1              0              0            288
Markdown                         3             29              0             97
YAML                             3              1              0             19
R                                2              1              3              5
JSON                             1              0              0              1
-------------------------------------------------------------------------------
SUM:                            68           2871           3598          20906
-------------------------------------------------------------------------------


Statistical information for the repository '4279c59c22f532017b9213c9' was
gathered on 2023/06/06.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Michael Hahsler                  7         10163           1919          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Michael Hahsler            8244           81.1          1.7               50.01

@whedon
Copy link
Author

whedon commented Jun 6, 2023

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@mhahsler
Copy link

mhahsler commented Jun 6, 2023

Here are two reviewer suggestions from the list:

  • Kelly Bodwin
  • Abhinav Maurya

@xuanxu
Copy link
Member

xuanxu commented Jun 19, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator

@openjournals openjournals deleted a comment from editorialbot Jun 19, 2023
@mhahsler
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator

@mhahsler
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator

@mhahsler
Copy link

@xuanxu the pdf generation script seems to die when adding an image (not finding the journal logo?)

Error running filter /usr/local/share/openjournals/data/filters/add-images.lua:
File  not found in resource path
stack traceback:
	/usr/local/share/openjournals/data/filters/add-images.lua:4: in upvalue 'insert'
	/usr/local/share/openjournals/data/filters/add-images.lua:9: in function 'Meta'

I am not sure how to fix this.

@xuanxu
Copy link
Member

xuanxu commented Jun 20, 2023

Yes, is something we are looking into, we've updated the PDF compilation step and this is probably some misconfiguration in our part.

@xuanxu
Copy link
Member

xuanxu commented Jun 21, 2023

@editorialbot generate pdf

let's try again

@editorialbot
Copy link
Collaborator

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@mhahsler
Copy link

@whedon commands

@editorialbot
Copy link
Collaborator

My name is now @editorialbot

@mhahsler
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator

Hello @mhahsler, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set jose-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@mhahsler
Copy link

@editorialbot list editors

@editorialbot
Copy link
Collaborator

List of JOSE editors

@IanHawke
@JasonJWilliamsNY
@ShanEllis
@acocac
@allisonhorst
@arm61
@ashleefv
@bryanwweber
@csev
@diazrenata
@emckiernan
@jgorzalski
@juanklopper
@kls2177
@kyleniemeyer
@labarba
@lorenanicole
@magsol
@moorepants
@nicoguaro
@quirksahern
@stats-tgeorge
@steflangehennig
@ttimbers
@willingc
@yabellini

@mhahsler
Copy link

mhahsler commented Aug 20, 2023

@labarba Hi. There was a technical issue with creating the pdf. The issue was resolved. What are the next steps for the review process? Best regards, Michael

@stats-tgeorge
Copy link

@mhahsler I apologize for the delay. Since it has been many month, can you confirm you would still like this reviewed?

@mhahsler
Copy link

mhahsler commented Jan 8, 2024

@stats-tgeorge Thank you for your reply. It has been a while, but we are still teaching the course and I am still interested having the companion reviewed.

@stats-tgeorge
Copy link

@editorialbot assign @stats-tgeorge as editor

@editorialbot
Copy link
Collaborator

Assigned! @stats-tgeorge is now the editor

@stats-tgeorge
Copy link

@mhahsler great! To start, looking at your JOSE paper there are some missing pieces. See mhahsler/Introduction_to_Data_Mining_R_Examples#5 (comment)

@stats-tgeorge
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator

Hello @stats-tgeorge, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author, a reviewer or the editor to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for branch
@editorialbot set jose-paper as branch

# Set a value for repository
@editorialbot set https://github.com/organization/repo as repository

# Set a value for the archive DOI
@editorialbot set set 10.5281/zenodo.6861996 as archive

# Mention the EiCs for the correct track
@editorialbot ping track-eic

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Creates a post-review checklist with editor and authors tasks
@editorialbot create post-review checklist

# Open the review issue
@editorialbot start review

@stats-tgeorge
Copy link

@editorialbot list reviewers

@editorialbot
Copy link
Collaborator

Here's the current list of reviewers: https://bit.ly/jose-reviewers

@stats-tgeorge
Copy link

Hello @kbodwin, Michael Hahsler has submitted a data mining companion book to JOSE for other instructors to use. Would you be willing to review the submission? Your time and efforts will be greatly appreciated!

@stats-tgeorge
Copy link

Hello @ahmaurya, Michael Hahsler has submitted a data mining companion book to JOSE for other instructors to use. Would you be willing to review the submission? Your time and efforts will be greatly appreciated!

@stats-tgeorge
Copy link

Hello @hughshanahan, Michael Hahsler has submitted a data mining companion book to JOSE for other instructors to use. Would you be willing to review the submission? Your time and efforts will be greatly appreciated!

@stats-tgeorge
Copy link

Hello @rudeboybert, Michael Hahsler has submitted a data mining companion book to JOSE for other instructors to use. Would you be willing to review the submission? Your time and efforts will be greatly appreciated!

@stats-tgeorge
Copy link

Good morning @mhahsler , I am still working on this. I will be reaching out to potential reviewers outside of Github. Please stay tuned and thank you for being very patient!

@stats-tgeorge
Copy link

Good morning @mhahsler I have identified two reviewers! They asked for a long deadline but at least we are making progress. I will be making some updates here to create the review version.

@stats-tgeorge
Copy link

@editorialbot assign @hughshanahan as reviewer

@editorialbot
Copy link
Collaborator

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@stats-tgeorge
Copy link

@editorialbot assign @hughshanahan as reviewer

@editorialbot
Copy link
Collaborator

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@stats-tgeorge
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator

Hello @stats-tgeorge, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author, a reviewer or the editor to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for branch
@editorialbot set jose-paper as branch

# Set a value for repository
@editorialbot set https://github.com/organization/repo as repository

# Set a value for the archive DOI
@editorialbot set set 10.5281/zenodo.6861996 as archive

# Mention the EiCs for the correct track
@editorialbot ping track-eic

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Creates a post-review checklist with editor and authors tasks
@editorialbot create post-review checklist

# Open the review issue
@editorialbot start review

@stats-tgeorge
Copy link

@editorialbot add @hughshanahan as reviewer

@editorialbot
Copy link
Collaborator

@hughshanahan added to the reviewers list!

@stats-tgeorge
Copy link

@editorialbot add @rudeboybert as reviewer

@editorialbot
Copy link
Collaborator

@rudeboybert added to the reviewers list!

@stats-tgeorge
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator

OK, I've started the review over in #223.

@stats-tgeorge
Copy link

Hello @gvdr, you are on our list of potential reviewers for JOSE. Michael Hahsler has submitted a data mining companion book to JOSE for other instructors to use. Would you be willing to review the submission? Your time and efforts will be greatly appreciated!

@stats-tgeorge
Copy link

Hello @trallard, you are on our list of potential reviewers for JOSE. Michael Hahsler has submitted a data mining companion book to JOSE for other instructors to use. Would you be willing to review the submission? Your time and efforts will be greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants