Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[REVIEW]: sbpy: A Python module for small-body planetary astronomy #1426
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@Juanlu001, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @xuanxu know.
Review checklist for @Juanlu001
Conflict of interest
Code of Conduct
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
Before I finish a proper review:
The license is stated in the README and also in https://github.com/NASA-Planetary-Science/sbpy/blob/master/licenses/LICENSE.rst. Not what I expected, but I guess it should be enough.
Sorry all for the delay! I finished the review, having paid more attention to the orbital stuff and installation and testing procedures. Some comments:
I left some boxes unchecked until the original authors clarify the status of the
Here are some replies to you general comments:
No, we simply haven't gotten around to register it with PyPI. Most likely we will wait for this until v0.2 is released in a few weeks.
The documentation for some of the modules (including
@Juanlu001 I think I implemented all the changes. My replies and corresponding changes in the code are linked in the corresponding issues:
NASA-Planetary-Science/sbpy#151 has already been closed.
All the changes are bundled in PR NASA-Planetary-Science/sbpy#156.
If there is anything else I can do, please let me know!
Here's what you must now do:
Any issues? notify your editorial technical team...
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: