-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: sbpy: A Python module for small-body planetary astronomy #1426
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @Juanlu001 it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
Before I finish a proper review:
The license is stated in the README and also in https://github.com/NASA-Planetary-Science/sbpy/blob/master/licenses/LICENSE.rst. Not what I expected, but I guess it should be enough. |
Hi @Juanlu001, thanks for reviewing this submission! Would you prefer the |
I think so @mommermi! Having a |
Ok, done! |
@whedon generate pdf |
|
@whedon generate pdf |
|
@Juanlu001 What's your status with the continued review of this submission? |
@xuanxu Had a tough |
@Juanlu001 friendly ping :) |
Sorry all for the delay! I finished the review, having paid more attention to the orbital stuff and installation and testing procedures. Some comments:
I left some boxes unchecked until the original authors clarify the status of the |
Thank, @Juanlu001, for your review! I will work my way through it and hopefully finish it this week. |
Here are some replies to you general comments:
No, we simply haven't gotten around to register it with PyPI. Most likely we will wait for this until v0.2 is released in a few weeks.
The documentation for some of the modules (including
|
@Juanlu001 I think I implemented all the changes. My replies and corresponding changes in the code are linked in the corresponding issues: NASA-Planetary-Science/sbpy#149 NASA-Planetary-Science/sbpy#151 has already been closed. All the changes are bundled in PR NASA-Planetary-Science/sbpy#156. If there is anything else I can do, please let me know! |
Excellent @mommermi! I checked all the boxes in the review and think this is good to go with NASA-Planetary-Science/sbpy#156. |
Thanks, @Juanlu001! I will wait with merging NASA-Planetary-Science/sbpy#156 until the astropy core issue is fixed and the CI builds succeed again. Thanks for your detailed review! |
And, of course, thanks to @bsipocz, too, for her comments and help! |
@whedon generate pdf |
Ok, the latest version is registered with zenodo. The DOI is 10.5281/zenodo.3252172 |
@whedon set v0.1.1 as version |
OK. v0.1.1 is the version. |
@whedon set 10.5281/zenodo.3252172 as archive |
OK. 10.5281/zenodo.3252172 is the archive. |
Yay! 🎉 |
@whedon accept |
|
|
Check final proof 👉 openjournals/joss-papers#787 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#787, then you can now move forward with accepting the submission by compiling again with the flag
|
@xuanxu - there are 2 typos in the papers, as indicated in NASA-Planetary-Science/sbpy#158 Once these are fixed (by merging this PR), we can finish the acceptance |
@mommermi - Can you merge NASA-Planetary-Science/sbpy#158 ? |
@whedon generate pdf |
|
@whedon accept |
|
|
Check final proof 👉 openjournals/joss-papers#788 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#788, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thanks to @Juanlu001 for reviewing and @xuanxu for editing |
Thank you all for the quick processing of this paper! |
Submitting author: @mommermi (Michael Mommert)
Repository: https://github.com/NASA-Planetary-Science/sbpy
Version: v0.1.1
Editor: @xuanxu
Reviewer: @Juanlu001
Archive: 10.5281/zenodo.3252172
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@Juanlu001, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @xuanxu know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @Juanlu001
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: