-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: traffic: a toolbox for processing and analysing air traffic data #1518
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @junzis, @espinielli it looks like you're currently assigned to review this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
Thanks for agreeing to review @junzis & @espinielli - instructions are above, which are basically to work through your checklists. I'lll also note here that @espinelli will be out for about a week soon. If you have any questions, please ask. |
Thank you for agreeing to review @junzis and @espinielli |
I, too, am writing (and presenting at UseR!2019: "R in the Air") an R package for flight trajectories 😇 |
@danielskatz - Do items from the checklist "Document" section also need to be included in the paper? Thanks! |
The documentation criteria is:
The paper needs are shown at the top of https://joss.readthedocs.io/en/latest/review_criteria.html |
@xoolive - The paper, library, and document all look great! Here are my minor comments:
|
Thank you @junzis for the feedback.
|
@xoolive - Thanks for your clarifications. In this case, my last two comments can be ignored. |
The archive link is not needed yet - we will add that at the end once any needed changes are made. (We're discussing changing this review criteria, but haven't settled on exactly how to yet.) |
👋 @espinielli - have you had a chance to start your review? |
@junzis Latest commit addresses your comment about the statement of need. |
@whedon generate pdf |
|
@danielskatz - I have completed all the checkboxes for the review process. Finally, the paper is good and documentation is complete from my point of view. I think it can be accepted. |
Thanks @junzis! |
I will start, this afternoon |
@xoolive I am trying to install as per https://traffic-viz.github.io/installation.html
Last failed: I am on a Mac where python is still 2.7.0, ok, so I installed "latest"
(I assume Python 3 is the norm these days, hence why you did not mentioned it in the documentation) |
Small suggestion for rewording in xoolive/traffic#28 |
Nothing stupid @espinielli, just regular Python mess 😄 Python 3 is indeed the norm these days, and the dependency is stated here. The installation process should fail if you have python<3.6. There are specific non-Python dependencies for two Python libraries, namely If you already have a working |
@whedon generate pdf |
|
@xoolive - we now need you to archive the software in an archival repository, such as zenodo (see https://guides.github.com/activities/citable-code/) or elsewhere that provides a DOI - then let me know the DOI of the archive. Also, is 2.0 still the correct version number? If not, let me know what is. |
Thank you @danielskatz Here is the link to the DOI: https://doi.org/10.5281/zenodo.3269812 |
@whedon set 10.5281/zenodo.3269812 as archive |
OK. 10.5281/zenodo.3269812 is the archive. |
@whedon accept |
|
|
Check final proof 👉 openjournals/joss-papers#818 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#818, then you can now move forward with accepting the submission by compiling again with the flag
|
@xoolive - please merge xoolive/traffic#32 |
@danielskatz done, I am not sure now about the whedon command to type in order to generate a new final proof |
@whedon generate pdf |
|
sorry, my fix didn't quite work for the cases - let's try again - please change the line in the bib file to: |
@whedon generate pdf |
|
@danielskatz this one looks good to me 😃 |
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@danielskatz @espinielli @junzis |
Submitting author: @xoolive (Xavier Olive)
Repository: https://github.com/xoolive/traffic
Version: v2.0
Editor: @danielskatz
Reviewer: @junzis, @espinielli
Archive: 10.5281/zenodo.3269812
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@junzis & @espinielli, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @junzis
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @espinielli
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: