Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Shop-Solver: A framework for solving and benchmarking shop scheduling problems #1735

Closed
whedon opened this issue Sep 16, 2019 · 27 comments

Comments

@whedon
Copy link

whedon commented Sep 16, 2019

Submitting author: @KingZee (Abdelhakim Zakkari)
Repository: https://github.com/KingZee/shop-solver
Version: v1.2.0
Editor: @gkthiruvathukal
Reviewers: @nnadeau, @nthomasCUBE

Author instructions

Thanks for submitting your paper to JOSS @KingZee. Currently, there isn't an JOSS editor assigned to your paper.

@KingZee if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Sep 16, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Sep 16, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Sep 16, 2019

PDF failed to compile for issue #1735 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/lib/whedon.rb:143:in block in check_orcids': Problem with ORCID (0000-0000-0000-0000) for Alami Semma (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/lib/whedon.rb:141:in each'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/lib/whedon.rb:141:in check_orcids' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/lib/whedon.rb:88:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/lib/whedon/processor.rb:36:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/lib/whedon/processor.rb:36:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:55:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@kthyng
Copy link

kthyng commented Sep 16, 2019

Hi @poulson can you edit this submission?

@KingZee
Copy link

KingZee commented Sep 16, 2019

Hi! I think that problem would be on my side, I forgot to change the placeholder ORCID of my supervisor I kept while writing the article. I have updated it now, apologies for the issue.

@kthyng
Copy link

kthyng commented Sep 16, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Sep 16, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Sep 16, 2019

@KingZee
Copy link

KingZee commented Sep 17, 2019

Maybe I can suggest some reviewers?
@PrashantVaidyanathan
@soroushj
@rljacobson
@dvberkel
@louiseadennis
@nthomasCUBE
@nnadeau
@hainesr
@nkratzke
@nuest
all seem like potential good fits.

@kthyng
Copy link

kthyng commented Sep 17, 2019

Thanks @KingZee for the suggestions.

@gkthiruvathukal Would you be able to edit this submission?

@gkthiruvathukal
Copy link

Hi @kthyng, yes, I can handle it. I am just returning from a long period of travel and have some other assignments in front of this one, but I should be able to get rolling on it by the weekend.

@kthyng
Copy link

kthyng commented Sep 18, 2019

@whedon assign @gkthiruvathukal as editor

@whedon
Copy link
Author

whedon commented Sep 18, 2019

OK, the editor is @gkthiruvathukal

@kthyng
Copy link

kthyng commented Sep 18, 2019

Thanks @gkthiruvathukal!

@gkthiruvathukal
Copy link

@PrashantVaidyanathan @soroushj @rljacobson @dvberkel @louiseadennis @nthomasCUBE @nnadeau @hainesr @nkratzke @nuest: Would any two of you be willing to contribute a review for this submission?

@engnadeau
Copy link

@gkthiruvathukal I’ll review

@nthomasCUBE
Copy link

nthomasCUBE commented Sep 20, 2019 via email

@gkthiruvathukal
Copy link

Thanks, @nnadeau and @nthomasCUBE. I'll get this going!

@gkthiruvathukal
Copy link

@whedon assign @nnadeau as reviewer

@whedon
Copy link
Author

whedon commented Sep 20, 2019

OK, the reviewer is @nnadeau

@gkthiruvathukal
Copy link

@whedon add @nthomasCUBE as reviewer

@whedon
Copy link
Author

whedon commented Sep 20, 2019

OK, @nthomasCUBE is now a reviewer

@gkthiruvathukal
Copy link

@whedon commands

@whedon
Copy link
Author

whedon commented Sep 20, 2019

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the sole reviewer of this submission
@whedon assign @username as reviewer

# Add a GitHub user to the reviewers of this submission
@whedon add @username as reviewer

# Remove a GitHub user from the reviewers of this submission
@whedon remove @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Set the software version at the top of the issue e.g.
@whedon set v1.0.1 as version

# Open the review issue
@whedon start review

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Remind an author or reviewer to return to a review after a
# certain period of time (supported units days and weeks)
@whedon remind @reviewer in 2 weeks

# Ask Whedon to accept the paper and deposit with Crossref
@whedon accept

# Ask Whedon to check the references for missing DOIs
@whedon check references

@gkthiruvathukal
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Sep 20, 2019

OK, I've started the review over in #1752. Feel free to close this issue now!

@poulson
Copy link

poulson commented Sep 22, 2019

Thank you for taking this over, @kthyng. I just got back from some overseas travel and forgot to put my OOO up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants