Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: GRLC - the Git Repository Linked data api Constructor #2220

Closed
whedon opened this issue May 22, 2020 · 51 comments
Closed

[PRE REVIEW]: GRLC - the Git Repository Linked data api Constructor #2220

whedon opened this issue May 22, 2020 · 51 comments

Comments

@whedon
Copy link

whedon commented May 22, 2020

Submitting author: @c-martinez (Carlos Martinez-Ortiz)
Repository: https://github.com/CLARIAH/grlc
Version: v1.3.4
Editor: @lorenanicole
Reviewers: @essepuntato, @alexdma
Managing EiC: Arfon Smith

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @c-martinez. Currently, there isn't an JOSS editor assigned to your paper.

@c-martinez if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented May 22, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 22, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.09 s (521.2 files/s, 50074.4 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
Python                           22            464            363           1749
Markdown                          4            132              0            380
HTML                              2             33              9            155
CSS                               1             28             32            135
JavaScript                        2             13             31            123
Bourne Shell                      6             22             31            116
TeX                               1              4              0             86
Bourne Again Shell                2             14             15             75
YAML                              3              3              4             56
Dockerfile                        1             13              1             36
JSON                              2              0              0             35
Jupyter Notebook                  1              0            419             20
INI                               1              2              0             13
--------------------------------------------------------------------------------
SUM:                             48            728            905           2979
--------------------------------------------------------------------------------


Statistical information for the repository '2220' was gathered on 2020/05/22.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Albert Merono                    2             7              2            0.01
Albert Meronyo                   3            96             41            0.09
Albert Meronyo-Penyu            15         35839            114           22.58
Albert Meroño-Peñuel           111          3692           1244            3.10
Albert Meroño-Peǹuel             2           118             15            0.08
Carlos                          21           488            119            0.38
Carlos Martinez                 92         40063          76510           73.21
Hoekstra, Rinke (ELS             5            35             15            0.03
Jonas                            1             1              1            0.00
Pasquale Lisena                 11           369            143            0.32
Rinke Hoekstra                  16           238             49            0.18
RoderickvanderWeerdt             2             2              2            0.00
mwigham                          1            10             20            0.02

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Albert Meroño-Peñuel        592           16.0         29.1               19.09
Carlos Martinez            1831            4.6         17.3               10.70
Hoekstra, Rinke (ELS         21           60.0         26.8                9.52
Pasquale Lisena             243           65.9         14.5               14.40
mwigham                       3           30.0         12.0                0.00

@whedon
Copy link
Author

whedon commented May 22, 2020

Reference check summary:

OK DOIs

- 10.18174/505685 is OK

MISSING DOIs

- https://doi.org/10.1007/978-3-030-30796-7_28 may be missing for title: Easy Web API Development with SPARQL Transformer
- https://doi.org/10.1007/978-3-319-47602-5_48 may be missing for title: grlc Makes GitHub Taste Like Linked Data APIs
- https://doi.org/10.1007/978-3-319-70407-4_27 may be missing for title: SPARQL2Git: Transparent SPARQL and Linked Data API Curation via Git
- https://doi.org/10.1007/978-3-319-68204-4_30 may be missing for title: Automatic Query-Centric API for Routine Access to Linked Data

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented May 22, 2020

@arfon
Copy link
Member

arfon commented May 22, 2020

👋 @c-martinez. Thanks for your submission to JOSS. As described in our blog post announcing the reopening of JOSS, we're currently working in a "reduced service mode", limiting the number of papers assigned to any individual editor.

Since reopening JOSS earlier in the week we've had > 50 papers submitted and as such, yours has been put in our backlog that we will be working through over the coming weeks and months.

Thanks in advance for your patience!

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label May 22, 2020
@danielskatz
Copy link

👋 @lorenanicole - would you be able to edit this submission?

@danielskatz
Copy link

@whedon invite @lorenanicole as editor

@whedon
Copy link
Author

whedon commented May 28, 2020

@lorenanicole has been invited to edit this submission.

@danielskatz danielskatz removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label May 28, 2020
@lorenanicole
Copy link

@whedon assign me as editor

@whedon
Copy link
Author

whedon commented May 28, 2020

OK, the editor is @lorenanicole

@lorenanicole
Copy link

lorenanicole commented Jun 4, 2020

@c-martinez, do you have any suggestions for reviewers for your submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

@openjournals openjournals deleted a comment from whedon Jun 4, 2020
@albertmeronyo
Copy link

Hi @lorenanicole , we think Jan Wielemaker (https://github.com/JanWielemaker) and Silvio Peroni (https://github.com/essepuntato) would be good choices

@lorenanicole
Copy link

Excellent, thank you @albertmeronyo!

@lorenanicole
Copy link

Greetings @JanWielemaker @essepuntato! Would you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines 👉 https://joss.readthedocs.io/en/latest/reviewer_guidelines.html.

@lorenanicole
Copy link

@JanWielemaker @essepuntato just wanted to check in to see if there was anything further you may need?

Greetings @JanWielemaker @essepuntato! Would you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines 👉 https://joss.readthedocs.io/en/latest/reviewer_guidelines.html.

@essepuntato
Copy link

essepuntato commented Jun 15, 2020

@JanWielemaker @essepuntato just wanted to check in to see if there was anything further you may need?

Hi @lorenanicole, apologies – I'm just back from holidays right now. I'll work on it as soon as possible. Would it be possible for me to work on it next week or it is too late?

Have a nice day :-)

@lorenanicole
Copy link

@essepuntato not too late at all! Just wanted to circle back in case we needed to find another editor. Thank you for following up! This comment will be of use to you 👇 #2220 (comment)

@lorenanicole
Copy link

@whedon invite @essepuntato as reviewer

@whedon
Copy link
Author

whedon commented Jun 17, 2020

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands

@lorenanicole
Copy link

@whedon commands

@whedon
Copy link
Author

whedon commented Jun 17, 2020

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the sole reviewer of this submission
@whedon assign @username as reviewer

# Add a GitHub user to the reviewers of this submission
@whedon add @username as reviewer

# Re-invite a reviewer (if they can't update checklists)
@whedon re-invite @username as reviewer

# Remove a GitHub user from the reviewers of this submission
@whedon remove @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Set the software version at the top of the issue e.g.
@whedon set v1.0.1 as version

# Open the review issue
@whedon start review

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Remind an author or reviewer to return to a review after a
# certain period of time (supported units days and weeks)
@whedon remind @reviewer in 2 weeks

# Ask Whedon to do a  dry run of accepting the paper and depositing with Crossref
@whedon accept

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository

EiC TASKS

# Invite an editor to edit a submission (sending them an email)
@whedon invite @editor as editor

# Reject a paper
@whedon reject

# Withdraw a paper
@whedon withdraw

# Ask Whedon to actually accept the paper and deposit with Crossref
@whedon accept deposit=true

@lorenanicole
Copy link

@whedon add @essepuntato as reviewer

@whedon
Copy link
Author

whedon commented Jun 26, 2020

OK, @essepuntato is now a reviewer

@lorenanicole
Copy link

@essepuntato can you let me know if this works?

@lorenanicole
Copy link

Hi 👋 @jonathanblaney, would you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines 👉 https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

@essepuntato
Copy link

essepuntato commented Jun 27, 2020 via email

@jonathanblaney
Copy link

@lorenanicole I don't think I'm the right person but am looking into other candidates, if that's OK with you?

@jonathanblaney
Copy link

Hi again @lorenanicole. I've asked around and @alexdma is prepared to review this.

@lorenanicole
Copy link

@jonathanblaney thanks for the additional reviewer.

@lorenanicole
Copy link

Hi @alexdma, circling back! would you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html!

@alexdma
Copy link

alexdma commented Aug 18, 2020

Hi @lorenanicole - yes, sorry for the delay in getting back to you, but I still do not quite understand where and how I am supposed to write my review. Do I have to open an issue here, comment on this one or... what? And where do I go to issue commands to whedon? The guidelines all seem to assume that I already am at the place where the review should be entered.

@labarba
Copy link
Member

labarba commented Sep 27, 2020

hi 👋 – @lorenanicole: it looks like the reviewer needs some guidance here. Can you pop in to help?

@openjournals/dev – can you check why a reviewer is listed twice on the header comment? Should this be edited manually?

@xuanxu
Copy link
Member

xuanxu commented Sep 27, 2020

can you check why a reviewer is listed twice on the header comment? Should this be edited manually?

He was added twice (in june 17th and 26th). I have edited it manually.

@lorenanicole
Copy link

@alexdma We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines 👉 https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. If you can please confirm, after reviewing these guidelines, that you are prepared to be a reviewer I can move us to the next step. We will open a separate issue for review.

@lorenanicole
Copy link

@alexdma We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines 👉 https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. If you can please confirm, after reviewing these guidelines, that you are prepared to be a reviewer I can move us to the next step. We will open a separate issue for review.

Greetings @alexdma just checking in to see if you needed help with the above?

@alexdma
Copy link

alexdma commented Oct 7, 2020

@lorenanicole thanks, but much as I may go over the guidelines, I cannot find in them the answer to my fundamental question.

Where do I find the review page with the checklist that I have to fill?

Here? I don't see the space to enter the review
On a new issue of this project? If I try to open one here, I get an automated message saying I must not create issues here.
I open an issue on the main GRLC repository? I have searched older issues there, and none of them seems to be a review.

So... where is the space for me to enter my review?

Thanks

@lorenanicole
Copy link

lorenanicole commented Oct 7, 2020

@alexdma your review will have on a separate GitHub issues upon confirming your intent to review, basically all I need is a "yes I will review" from you. Then we'll (as in I will) use our JOSS tooling to open the review issue for your work to start! An example of a review issue is here: #2727.

Does that help answer your question?

@alexdma
Copy link

alexdma commented Oct 7, 2020

I see. Yes, of course I will review: I had assumed my intent was known since I had originally confirmed it by email, and was stuck looking for the place to get started. Sorry for the misunderstanding.

@lorenanicole
Copy link

No worries whatsoever @alexdma! I appreciate the prompt feedback!

@lorenanicole
Copy link

@whedon add @alexdma as reviewer

@whedon
Copy link
Author

whedon commented Oct 7, 2020

OK, @alexdma is now a reviewer

@lorenanicole
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Oct 7, 2020

OK, I've started the review over in #2731.

@whedon whedon closed this as completed Oct 7, 2020
@lorenanicole
Copy link

OK, I've started the review over in #2731.

Yay! @alexdma @essepuntato we are as the above states ☝️ moving review over to #2731. @c-martinez we'll be in touch as needed.

@c-martinez
Copy link

Great -- thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests