-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: qGaussian: An R package that deal with the Tsallis statistics #229
Comments
👋 @jakevdp - the submitting author suggested you as the editor. Let me know if you would like to find someone else for this. |
@whedon assign @cdcrabtree as reviewer
2017-04-05 21:59 GMT-03:00 whedon <notifications@github.com>:
… *Submitting author:* @bunhoel <https://github.com/bunhoel> (Emerson
<http://orcid.org/0000-0002-9970-3544>)
*Repository:* <https://github.com/bunhoel/anvil/tree/master/qGaussian>
https://github.com/bunhoel/anvil/tree/master/qGaussian
*Version:* v0.1.4
*Editor:* @jakevdp <https://github.com/jakevdp>
*Reviewer:* Pending
*Author instructions*
Thanks for submitting your paper to JOSS @bunhoel
<https://github.com/bunhoel>. The JOSS editor (shown at the top of this
issue) will work with you on this issue to find a reviewer for your
submission before creating the main review issue.
@bunhoel <https://github.com/bunhoel> if you have any suggestions for
potential reviewers then please mention them here in this thread. In
addition, this list of people
<https://github.com/openjournals/joss/blob/master/docs/reviewers.csv>
have already agreed to review for JOSS and may be suitable for this
submission.
*Editor instructions*
The JOSS submission bot @whedon <https://github.com/whedon> is here to
help you find and assign reviewers and start the main review. To find out
what @whedon <https://github.com/whedon> can do for you type:
@whedon commands
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#229>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AZoQpQMB_yMDbfdZnYhfiBoBCGppP3M-ks5rtDjhgaJpZM4M0_k8>
.
|
I'm sorry @bunhoel, I'm afraid I can't do that. That's something only JOSS editors are allowed to do. |
The suggestion for potential reviewers
cdcrabtree
masalmon
wrathematics
2017-04-05 21:59 GMT-03:00 whedon <notifications@github.com>:
… *Submitting author:* @bunhoel <https://github.com/bunhoel> (Emerson
<http://orcid.org/0000-0002-9970-3544>)
*Repository:* <https://github.com/bunhoel/anvil/tree/master/qGaussian>
https://github.com/bunhoel/anvil/tree/master/qGaussian
*Version:* v0.1.4
*Editor:* @jakevdp <https://github.com/jakevdp>
*Reviewer:* Pending
*Author instructions*
Thanks for submitting your paper to JOSS @bunhoel
<https://github.com/bunhoel>. The JOSS editor (shown at the top of this
issue) will work with you on this issue to find a reviewer for your
submission before creating the main review issue.
@bunhoel <https://github.com/bunhoel> if you have any suggestions for
potential reviewers then please mention them here in this thread. In
addition, this list of people
<https://github.com/openjournals/joss/blob/master/docs/reviewers.csv>
have already agreed to review for JOSS and may be suitable for this
submission.
*Editor instructions*
The JOSS submission bot @whedon <https://github.com/whedon> is here to
help you find and assign reviewers and start the main review. To find out
what @whedon <https://github.com/whedon> can do for you type:
@whedon commands
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#229>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AZoQpQMB_yMDbfdZnYhfiBoBCGppP3M-ks5rtDjhgaJpZM4M0_k8>
.
|
👋 @cdcrabtree @masalmon @wrathematics would one of you be willing to review this submission for JOSS? |
Sorry, I somehow lost track of this among all my other github emails. This is neither my area of expertise, nor the code community where I have connections, and so I don't think I'd be a good editor for this submission. |
👋 @karthik - would you be willing to edit this submission for JOSS? |
OK, the editor is @karthik |
Hi @bunhoel
I stopped there. I would suggest that you read over the package development from Hadley Wickham (available here for free: http://r-pkgs.had.co.nz/) and fix everything up. If you are happy to go this route and ping us again when your package is ready, please let us know and I will add a |
Dear Karthik I greatly appreciate the suggestions and I believe that all pending questions was solved. Finally, I suspect that it is more productive to consider the new |
Hi @bunhoel,
|
Dear Karthik
|
@bunhoel Can you please inform us of your plans with this package?
This is not the right way to do it. You should not extract content from the built package back to source. As mentioned before, please read over the relevant chapters of Hadley Wickham's book on R packaging. |
Dear Karthik We following the request on how to implement the R packages using the
The package can now be installed by the command: Finally, it was also compiled by .travis.yml, and the qGaussian repository has now been put into the github standard. We hopefully the package will now be in aggree the github standard. |
Thanks for the nudge @arfon. Taking a look now. |
Thanks @bunhoel Potential problems and suggestions for your package
|
I spoke too soon. One remaining issue before I assign a reviewer is that you are missing unit tests. Once you add those and some code coverage, I will proceed with your submission. |
Dear Karthik we believe to fixed all potential problems as like unit test, as same time, we implement the suggestions for the package. |
@bunhoel The package still far from us being able to send out to review:
Package is also failing a few basic checks: Given the the lack of progress, I'm going to pause this submission. Please ping once your package is in a state where it can be sent out for review. |
Dear Karthik, the first thing that we did was to delete from github the directory /bun hole/anvil/tree/master/q Gaussian All of ours works could be found at link https://github.com/bunhoel/qGaussian About more listed problems; test was includes, Rd files was edited by the roxygen2 and was included at readme Finally, paper was improved with a more details about R package and related theory. |
I'm going through old reviews and this one still appears to be well below the standard we would expect to pass a JOSS review. At this point I'm going to close this review. @bunhoel - please feel free to re-submit in the future if you manage to extend/improve this submission to meet the expectations set in our review criteria |
Submitting author: @bunhoel (Emerson)
Repository: https://github.com/bunhoel/anvil/tree/master/qGaussian
Version: v0.1.4
Editor: @karthik
Reviewer: Pending
Author instructions
Thanks for submitting your paper to JOSS @bunhoel. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.
@bunhoel if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:
The text was updated successfully, but these errors were encountered: