-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: s4rdm3x: A Tool Suite to Explore Code to Architecture Mapping Techniques #2791
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @kinow, @xirdneh it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
PDF failed to compile for issue #2791 with the following error: /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in |
@gkthiruvathukal hi, do you have karma to re-generate the article? I think the bot failed to do so, and I think I need it to complete the review checklist items for the paper. Please. Thank you! |
@whedon generate pdf |
Thanks! |
@gkthiruvathukal Sorry I didn't get to your request as fast as @arfon, @kinow. Looks like we're good now. |
👋 @kinow, please update us on how your review is going. |
👋 @xirdneh, please update us on how your review is going. |
My review is complete @gkthiruvathukal ✔️ Even managed to test Didn't get fully familiar with the rest of the interface and metrics, but looks really useful for developers inspecting code bases, and getting familiar with new architectures. I used IntelliJ's diagram builder to remind me of some of the relationships, but in the past I used Stan4J that would be a good tool to help users to create commons-imaging.sysmdl# name Apache Commons Imagingjarcommons-imaging-1.0-alpha2.jar root-packagesorg/apache/commons/imaging/ metrics file#commons-imaging-file-metrics.csv modulesbase mapping<high_level_module> <regular_expression>base org.apache.commons.imaging.color.[^.]* relations<source_module> <target_module>base icc Thank you for your patience and help with the issues found during the review @tobias-dv-lnu! |
Awesome! @kinow: Do you consider the sysmdl for commons imaging to be "correct"? If so would can I include it in the repo as an available system (always on the lookout for more data :) ) And thank you for the feedback and found problems! |
Not yet, but I will open a draft pull request. We can discuss how to improve it. I didn't understand how to use all the options and settings, and for the I've created a draft PR: h0bb3/s4rdm3x#14 |
Having some trouble testing a couple of things on the paper. I think it has to do with my local setup, I am currently tweaking some thing and will try to finish this over the weekend. |
@xirdneh: just let me know if I can help :) |
@xirdneh Just checking on how things are coming along with your review. I'm definitely not trying to rush you but would like to see if we are getting closer. @kinow Am I correct in interpreting your review as being complete and ready to recommend acceptance, or are their still issues requiring attention? |
@whedon set v1.3 as version |
OK. v1.3 is the version. |
@whedon accept |
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2077 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2077, then you can now move forward with accepting the submission by compiling again with the flag
|
|
@tobias-dv-lnu, it looks like DOIs may be available but missing for a number of your references. Can you please check these, and add if appropriate? I will then be able to accept the submission. Thanks! |
Thanks, @kyleniemeyer for helping to bring this to closure! :) |
@kyleniemeyer Thanks! Just added the missing DOIs in the paper.bib file (whedon had made the correct guesses on the DOIs), everything should be ok now I hope :) |
@whedon check references |
|
@whedon accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2078 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2078, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@kinow, @xirdneh - many thanks for your reviews here and to @gkthiruvathukal for editing this submission. JOSS relies upon the volunteer efforts of folks like yourselves and we simply wouldn't be able to do this without you! ✨ @tobias-dv-lnu - your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@kinow, @xirdneh, @gkthiruvathukal, @arfon : Thank you all for making this happen! |
Thank you for writing the article and having patience with the review process @tobias-dv-lnu . And thanks to all involved too 💐 ! |
Submitting author: @tobias-dv-lnu (Tobias Olsson)
Repository: https://github.com/tobias-dv-lnu/s4rdm3x
Version: v1.3
Editor: @gkthiruvathukal
Reviewer: @kinow, @xirdneh
Archive: 10.5281/zenodo.4475664
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@kinow & @xirdneh, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @gkthiruvathukal know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @kinow
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @xirdneh
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: