-
-
Notifications
You must be signed in to change notification settings - Fork 37
-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: The psyplot interactive visualization framework #363
Comments
Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @Fil it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
@Fil - please carry out your review in this issue by updating the checklist above and giving feedback in this issue. The reviewer guidelines are available here: http://joss.theoj.org/about#reviewer_guidelines Any questions/concerns please let me know. |
@arfon this is my first review, so maybe my question is obvious: where is the "thing" that I'm reviewing? (not the software, which I found, but the paper that will be published — probably something named |
Hi @Fil. JOSS reviews are primarily about the software (https://github.com/Chilipp/psyplot.git). We also ask that you check that the associated paper (https://github.com/Chilipp/psyplot/blob/master/paper.md) meets the recommended structure/content requirements. |
Yes absolutely. I'm mostly offline atm so was doing the simple admin things — will do the install later next week |
@Chilipp I've followed the installation procedure (conda in a virtualenv) and I can't seem to get the plot as a graphics. Here's what I get in a jupyter notebook (after I was hoping to get the map as in the example http://psyplot.readthedocs.io/en/latest/getting_started.html Alternatively, I couldn't find how to launch the psyplot gui (from http://psyplot.readthedocs.io/projects/psyplot-gui/en/latest/getting_started.html). (EDIT: found it via spotlight…) |
This change should help to avoid situations as in openjournals/joss-reviews#363 (comment) [skip ci]
This should avoid problems like in openjournals/joss-reviews#363 (comment) [skip ci]
@Fil , thanks a lot for the feedback and your typo corrections! I added notes to the docs of psyplot, which should solve this problem (see the 2 first notes in the Getting started example. Additionally I included a section in the psyplot-gui docs on how to start the GUI. |
About the "Community Guidelines" item: the package's README only hints a github issues; it could say a bit more clearly how to contribute, and for example if pull requests, examples, and documentation are welcome. |
About "References", please fix the references DOI:
|
Solves openjournals/joss-reviews#363 (comment) [skip ci]
Solves openjournals/joss-reviews#363 (comment) [skip ci]
Thanks for your comments and your time! |
@Chilipp - At this point could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission. |
@arfon, I will use Zenodo for it. However I encountered a bug on their page. A couple of months ago, the psyplot repository has been deleted and created new from scratch. Now I cannot enable it again for Zenodo. I contacted Zenodo and would like to wait for their response. Otherwise I could only provide a DOI of the psyplot-conda repository, which provides the installers for psyplot. |
Agreed. Let's wait for their response here. |
@arfon, I thought a bit more about it and I now think that it makes the most sense to use the DOI for psyplot-conda I just created This would be the best for the JOSS paper, I think, because this archive then also includes the plugins psy-simple, psy-maps and psy-reg and the GUI, plus the installers, which have also been tested by @Fil. |
@whedon set 10.5281/zenodo.845455 as archive |
I'm sorry @Chilipp, I'm afraid I can't do that. That's something only JOSS editors are allowed to do. |
@whedon set 10.5281/zenodo.845455 as archive |
OK. 10.5281/zenodo.845455 is the archive. |
@Fil - many thanks for your review here ✨ @Chilipp - your paper now accepted into JOSS and your DOI is http://dx.doi.org/10.21105/joss.00363 ⚡️ 🚀 💥 |
Submitting author: @Chilipp (Philipp S. Sommer)
Repository: https://github.com/Chilipp/psyplot.git
Version: v1.0.0
Editor: @arfon
Reviewer: @Fil
Archive: 10.5281/zenodo.845455
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer questions
@Fil, please carry out your review in this issue by updating the checklist below (please make sure you're logged in to GitHub). The reviewer guidelines are available here: http://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @arfon know.
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: