-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: vSmartMOM.jl: an Open-Source Julia Package for Atmospheric Radiative Transfer and Remote Sensing Tools #4575
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @arjunsavelConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @jimmielinConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hello all, I've had an opportunity to look at this package during the pre-review phase, and have just went through the software and manuscript again. Please find my comments below. Summary
Functionality
...
# Architecture (default_architecture, GPU(), CPU())
architecture: default_architecture
... Simply noting
Documentation
Software paper
Technical Corrections
|
Hi @jimmielin @arjunsavel , thanks for the reviews so far! @RupeshJey you may already update your repository following the review by @jimmielin and keep us updated here. Reviews with JOSS can be interactive in this way. |
Hi all, I've finished my look at this package! With Firstly, I have some minor paper and documentation comments, which are grouped in issues in the code repository: Beyond these issues, I was curious about the authors' thoughts on the code's demos. They appear to constitute a potentially valuable set of additional examples and use cases, but there are some obstacles to their immediate application. For instance, they reference what I surmise to be a past name for |
Apologies for the late replies, we just started going through everything. As for demos, we saw now that they are indeed deprecated. It is likely best to remove the demos from that specific folder and make them part of the documentation, so that they are run automatically with every push, allowing us to see deprecation issues immediately. Thanks for catching that. We will go through the remaining issues soon as well. |
Hi @cfranken what is the progress regarding the issues raised by the reviewers? |
Just leaving an update that we've made great progress on all the feedback made above. We've made suggested modifications to the paper and documentation. We are in the process of fixing a bunch of the technical issues like dead links, citation issues, etc. |
Thanks for the update @RupeshJey , let us know when it is appropriate for the reviewers to take a new look at the repository/doc/paper. |
@RupeshJey any news? |
Hi Pierre, just wrapped up on our side! We’ve addressed the concerns listed in the above reviews. Here’s a mostly-exhaustive list of the changes:
There were a couple of points on the paper that we wanted to note as well:
Main branch: https://github.com/RemoteSensingTools/vSmartMOM.jl Thanks all! |
@editorialbot generate pdf |
Thanks @RupeshJey for the update! I have Julia 1.5 and tried to install according to the instructions: (
Can you remove the data tables from the article file? It is better to have a link to the documentation, not only because tables in pdfs are hard to use but also to keep with JOSS' guidelines to have brief articles. The citations yurchenko2012exomol:2012 roth-63 man2010hitemp:2010 have a syntax issue. |
@jimmielin @arjunsavel can you have a look at the updated version? |
@RupeshJey there is also an issue with the copyright text in the README. The "all rights reserved" and the provisions for commercial use are not aligned with the Apache license. Please only keep the mention of apache licensing. You may keep the acknowledgement of course. |
Thanks for your patience, all! The issues that I raised earlier have been sufficiently addressed, and I recommend this project for publication. Nicely done! |
|
👋 @openjournals/ese-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3767, then you can now move forward with accepting the submission by compiling again with the command |
Thanks for the fixes |
Hi @RupeshJey! I'm helping to wrap up this publication, however, I see some capitalization errors in your references. For example it looks like "Mie" should be capitalized but it isn't always. Also in your Grant et al references, there is an "i" instead of "I". These are just two examples, please look through your references in detail to correct all errors. You can preserve capitalization with {} around characters. |
we added {} for the titles (bibtex should automatically keep capitalization for titles ideally, this has always been annoying!). |
@editorialbot generate pdf |
@cfranken agreed it is annoying about capitalization! Ok this all looks good to go now. |
@editorialbot accept |
|
|
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats on your new publication @RupeshJey! Many thanks to editor @pdebuyl and reviewers @jimmielin and @arjunsavel for your time, hard work, and expertise!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@pdebuyl @jimmielin @arjunsavel @kthyng @cfranken Thank you all very much for your help throughout the process! Really grateful for the JOSS community and contributors. |
I second @RupeshJey, this has been a great process at JOSS, other journals should learn from it (instead of charging an arm and a leg). |
Thanks for the feedback! |
Submitting author: @RupeshJey (Rupesh Jeyaram)
Repository: https://github.com/RemoteSensingTools/vSmartMOM.jl
Branch with paper.md (empty if default branch): joss
Version: v1.0.1
Editor: @pdebuyl
Reviewers: @jimmielin, @arjunsavel
Archive: 10.5281/zenodo.7373457
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@jimmielin & @arjunsavel, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @pdebuyl know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @arjunsavel
📝 Checklist for @jimmielin
The text was updated successfully, but these errors were encountered: