Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Carnival: JVM Property graph data unification toolkit #4833

Closed
editorialbot opened this issue Oct 9, 2022 · 53 comments
Closed
Assignees
Labels
Cypher Dockerfile Groovy pre-review TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Oct 9, 2022

Submitting author: @hjwilli (Heather Williams)
Repository: https://github.com/carnival-data/carnival
Branch with paper.md (empty if default branch): joss2
Version: V2.1.5
Editor: @majensen
Reviewers: @kinow, @KonradHoeffner
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/77c829339608b3faaa92cc1baa7a012c"><img src="https://joss.theoj.org/papers/77c829339608b3faaa92cc1baa7a012c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/77c829339608b3faaa92cc1baa7a012c/status.svg)](https://joss.theoj.org/papers/77c829339608b3faaa92cc1baa7a012c)

Author instructions

Thanks for submitting your paper to JOSS @hjwilli. Currently, there isn't a JOSS editor assigned to your paper.

@hjwilli if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Oct 9, 2022
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.01 s (603.8 files/s, 27170.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              1              5              0             81
Markdown                         2             14              0             57
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                             4             20              4            156
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1101

@editorialbot
Copy link
Collaborator Author

Failed to discover a valid open source license

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3233/SHTI190178 is OK

MISSING DOIs

- 10.1007/978-3-662-46641-4_40 may be a valid DOI for title: Karma: A System for Mapping Structured Sources into the Semantic Web

INVALID DOIs

- https://doi.org/10.1016/j.jbi.2019.103208 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.jbi.2008.08.010 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.yjbinx.2020.100086 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon
Copy link
Member

arfon commented Oct 9, 2022

@hjwilli – it seems like @editorialbot doesn't know how to analyse your repository. Could you point me to where the source code is located?

@editorialbot editorialbot added Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning and removed Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Oct 11, 2022
@kthyng
Copy link

kthyng commented Oct 11, 2022

I am going to pause this submission until we get a response to @arfon's question.

@kthyng kthyng added the paused label Oct 11, 2022
@hjwilli
Copy link

hjwilli commented Oct 12, 2022

Hi @arfon, the source code is located in the /app directory.
https://github.com/carnival-data/carnival/tree/master/app

The license file and optional docker configuration are located at the root of the project.

@hjwilli
Copy link

hjwilli commented Oct 20, 2022

Hi @arfon and @kthyng, just following up on this. Please let me know if there is anything needed from my team to proceed. Thanks!

@hjwilli
Copy link

hjwilli commented Oct 20, 2022

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@hjwilli
Copy link

hjwilli commented Oct 20, 2022

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @hjwilli, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@kthyng
Copy link

kthyng commented Oct 21, 2022

Hi @hjwilli! We've just this week switched to a track-based managing editor set up so I will ping the AEIC in charge of this track to move forward.

@kthyng
Copy link

kthyng commented Oct 21, 2022

@editorialbot ping track-eic

@editorialbot
Copy link
Collaborator Author

🛎️❗Hey @openjournals/dsais-eics, this submission requires your attention.

@gkthiruvathukal
Copy link

Thanks, @kthyng. I will be on the case shortly. I'm still trying to get into the rhythm for inviting editors, etc. I will ping you on our Slack since you're already an expert.

@hjwilli
Copy link

hjwilli commented Nov 3, 2022

Hi JOSS team, my team came up with some potential reviewers for this paper. Please let us know if there is anything you need from us to move things forward! Thank you!

mgiardino
chaoran-chen
KonradHoeffner
ThomasThelen
reality
kinow
wetneb
UTH-Tuan

@gkthiruvathukal
Copy link

Hi, this is the new track editor, @gkthiruvathukal checking in. I am working to get this and a growing number of track submissions reviewed. Please do bear with me (and JOSS) as there is a bit of a backlog with many of our editors at maximum number of assignments they can edit at the moment. Thank you for your patience and understanding.

@gkthiruvathukal
Copy link

@arfon Is there some editorialbot magic to re-run the gitinspector statistics? We have a proper repository now.

@danielskatz
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.01 s (375.4 files/s, 16989.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              1              5              0             82
Markdown                         2             14              0             57
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                             4             20              4            157
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1101

@arfon
Copy link
Member

arfon commented Dec 13, 2022

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.21 s (971.5 files/s, 166244.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Groovy                         146           7463           5945          16706
Markdown                        35            912              0           2170
Gradle                           7            184            211            598
YAML                            10             18              8            139
XML                              2             49             25            120
Bourne Shell                     1             27            108             99
TeX                              1              5              0             82
DOS Batch                        1             21              2             66
RAML                             1             10              1             59
Dockerfile                       1             15             10             25
-------------------------------------------------------------------------------
SUM:                           205           8704           6310          20064
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1101

@arfon arfon removed the paused label Dec 26, 2022
@arfon
Copy link
Member

arfon commented Dec 26, 2022

@editorialbot invite @majensen as editor

👋 @majensen – would you be willing to edit this submission for JOSS?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@majensen
Copy link
Member

@editorialbot set me as editor

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@majensen
Copy link
Member

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @majensen is now the editor

@majensen
Copy link
Member

Apologies for being away - I will get going on recruiting reviewers

@majensen
Copy link
Member

Hi @KonradHoeffner -- would you have time and willingness to review this work for JOSS? I would really appreciate your expertise - vielen Dank!
--@majensen

@majensen
Copy link
Member

Oi @kinow - would you be able to review this work for JOSS? I appreciate your consideration - muito obrigado! --@majensen

@kinow
Copy link

kinow commented Jan 29, 2023

Oi @majensen 👋 !

would you be able to review this work for JOSS?

Sure thing, I had a quick read at the readme and it looks interesting to read & review 👍

Cheers

@majensen
Copy link
Member

@editorialbot add @kinow as reviewer

@editorialbot
Copy link
Collaborator Author

@kinow added to the reviewers list!

@KonradHoeffner
Copy link

@majensen absolutely, this looks very interesting, I'm in!

@majensen
Copy link
Member

@editorialbot Add @KonradHoeffner As reviewer

@editorialbot
Copy link
Collaborator Author

@KonradHoeffner added to the reviewers list!

@KonradHoeffner
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@majensen
Copy link
Member

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5117.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cypher Dockerfile Groovy pre-review TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

10 participants