New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: fRAT: an interactive, Python-based tool for region-of-interest summaries of functional imaging data #5200
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
Wordcount for |
👋🏼 @elliohow @ZeitgeberH @billbrod this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering
as the top of a new comment in this thread. There are additional guidelines in the message at the start of this issue. Please feel free to ping me (@mstimberg) if you have any questions/concerns. |
Review checklist for @ZeitgeberHConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @billbrodConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
👋 @billbrod no hurry performing the actual review, of course, but could I ask you to check the first two boxes (conflict of interest/code of conduct) of the checklist fairly soon (or let me know if you have any issue, obviously!)? Thanks! |
Issue regarding running fRAT on WSL2: |
Hi @elliohow |
Yes, I want to second this. In particular -- to what extent is fRAT an infrastructure / facilitation tool (like Nipype or fMRIPrep), making it easier to correctly run analyses that can be already be done using existing tools, and to what extent is it implementing novel (analysis, visualization, statistical) methods? |
@mstimberg , this is more of a question about JOSS (since this is my first review) -- does JOSS allow / encourage explicit descriptions of author contributions? @elliohow has written (essentially) all the code and, following standard procedure in neuroscience/psychology, I'm thus assuming the other two authors are supervisors / involved in the conception of the package, but that's not made explicit anywhere. Should it be? |
Hi @billbrod. JOSS does not currently require/encourage contribution statements as part of the paper, but the authors are welcome to clarify contributions here on the reviewing thread. The basic JOSS policy is that the authors themselves assume responsibility for who should be credited, and that all co-authors agree to be accountable for all aspects of the work. Code contributions are just one possible type of contribution and definitely not mandatory to be a co-author. On the other hand, we do ask for some active involvement in the project (i.e. just being the head of a research group isn't enough). Hope that makes things clearer! |
Yes, thank you! |
👋 @elliohow I saw that you've already discussed and fixed some of the issues raised by the reviewers 😊 |
@mstimberg Have had a bit of friction getting |
Great, thanks for the feedback 👍 . |
@editorialbot check references |
|
@editorialbot set 10.5281/zenodo.7877605 as archive |
Done! archive is now 10.5281/zenodo.7877605 |
@editorialbot set 1.4.0 as version |
Done! version is now 1.4.0 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4197, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
I'm sorry @schluppeck, I'm afraid I can't do that. That's something only eics are allowed to do. |
@elliohow @mstimberg I've reviewed the archive, the repository, and the paper and all seems in order. I will now proceed to accept this work in JOSS. |
@editorialbot accept |
|
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@elliohow congratulations on this paper! @mstimberg thanks for editing, and a special thanks to the reviewers: @ZeitgeberH, @billbrod |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thank you @billbrod, @ZeitgeberH & @mstimberg for being so thorough in your reviews, the software and paper has benefited immensely from the process, especially in terms of making |
Happy to review, glad it was useful, and congrats on the acceptance! |
Submitting author: @elliohow (Elliot Howley)
Repository: https://github.com/elliohow/fMRI_ROI_Analysis_Tool
Branch with paper.md (empty if default branch):
Version: 1.4.0
Editor: @mstimberg
Reviewers: @ZeitgeberH, @billbrod
Archive: 10.5281/zenodo.7877605
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@ZeitgeberH & @billbrod, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mstimberg know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @ZeitgeberH
📝 Checklist for @billbrod
The text was updated successfully, but these errors were encountered: