New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: pyGeo: A geometry package for multidisciplinary design optimization #5319
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
👋 @drvinceknight - how is this review coming along? I can't tell if anything has happened since it started. |
@danielskatz This is a very powerful package for the airplane outer model line design, which enables a high-fidelity MDAO study. I have followed this optimization framework for a while. I have no problem with the manuscript just a minor question about the claim given in Line 54, “Design variables formulated from groupings of FFD control points often exhibit ill conditioning”, do you have any relevant reference to support this, or was it studied in Wu et al. 2022? The manuscript has covered relevant information and meets the JOSS criteria, https://joss.readthedocs.io/en/latest/review_criteria.html. Good work! |
@zhaowei0566 would you be able to complete your review checklist please?
Likewise, @HaoZeke if you could let me know how the review is going that would be appreciated. |
Review checklist for @zhaowei0566Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot generate pdf |
This was studied in Wu et al. 2022. I moved the reference to clarify this @zhaowei0566. |
Thanks, @hajdik, I have no further question. |
Thanks @zhaowei0566, can I double check that all the points in your checklist are now complete? |
@drvinceknight Yes, I have completed the checklist. |
Great, thanks @zhaowei0566. |
@editorialbot check references |
|
@editorialbot generate pdf |
This looks good to me. Could you make a tagged release and archive, and report the version number and archive DOI in the review thread. Please make sure the archive deposit has the correct metadata (title and author list) which must match the paper. |
Hi @drvinceknight, we have released a version which is archived on zenodo. The paper branch has also changed to |
Done! branch is now main |
@editorialbot generate pdf |
Thanks for your patience, taking care of this now. |
@editorialbot set 10.5281/zenodo.8027706 as archive |
Done! archive is now 10.5281/zenodo.8027706 |
@editorialbot set v1.13.0 as version |
Done! version is now v1.13.0 |
@editorialbot recommend-accept |
|
|
ID ref-Brelje2021a already defined |
paper.bib has been updated to remove the duplicate citation. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4410, then you can now move forward with accepting the submission by compiling again with the command |
@hajdik - I'm now proofreading this paper to get ready to process it further towards publication. While I do so, I notice that the zenodo archive doesn't have any ORCIDs for the authors, while the paper does. If you want to, you can edit the Zenodo metadata to add ORCIDs. This is up to you to decide. |
@editorialbot accept This all looks good, so I'm going forward with accepting it (the zenodo metadata can still be changed, if you want, as it's independent) |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @hajdik (Hannah Hajdik) and co-authors on your publication!! And thanks to @HaoZeke and @zhaowei0566 for reviewing, and to @drvinceknight for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
🌈 Paper updated! New PDF and metadata files 👉 openjournals/joss-papers#5322 |
Submitting author: @hajdik (Hannah Hajdik)
Repository: https://github.com/mdolab/pygeo
Branch with paper.md (empty if default branch): main
Version: v1.13.0
Editor: @drvinceknight
Reviewers: @HaoZeke, @zhaowei0566
Archive: 10.5281/zenodo.8027706
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@HaoZeke & @zhaowei0566, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @drvinceknight know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @zhaowei0566
The text was updated successfully, but these errors were encountered: